Fix wrong xorm Delete usage

[lng2020]

Bug in Gitea

I ran into this bug when I accidentally used the wrong redirect URL for the oauth2 provider when using mssql. But the oauth2 provider still got added.
Most of the time, we use Delete(&some{id: some.id}) or In(condition).Delete(&some{}), which specify the conditions. But the function uses Delete(source) when source.Cfg is a TEXT field and not empty. This will cause xorm Delete function not working in mssql.

gitea/models/auth/source.go

Lines 234 to 240 in 61ff91f

	err = registerableSource.RegisterSource()
	if err != nil {
	// remove the AuthSource in case of errors while registering configuration
	if _, err := db.GetEngine(ctx).Delete(source); err != nil {
	log.Error("CreateSource: Error while wrapOpenIDConnectInitializeError: %v", err)
	}
	}

Reason

Because the TEXT field can not be compared in mssql, xorm doesn't support it according to this PR
related code in xorm

if statement.dialect.URI().DBType == schemas.MSSQL && (col.SQLType.Name == schemas.Text ||
   col.SQLType.IsBlob() || col.SQLType.Name == schemas.TimeStampz) {
   if utils.IsValueZero(fieldValue) {
     continue
   }
   return nil, fmt.Errorf("column %s is a TEXT type with data %#v which cannot be as compare condition", col.Name, fieldValue.Interface())
   }
}

When using the Delete function in xorm, the non-empty fields will auto-set as conditions(perhaps some special fields are not?). If TEXT field is not empty, xorm will return an error. I only found this usage after searching, but maybe there is something I missing.

[lng2020]

Question: I didn't use db.WithTX there because registerableSource.RegisterSource() didn't have a context and it will use third-party function. Should the context be added?

[lng2020]

CI failure is not related. Looks like the docker hub somehow not responding.

[GiteaBot]

I was unable to create a backport for 1.20. @lng2020, please send one manually. 🍵

go run ./contrib/backport 27995
...  // fix git conflicts if any
go run ./contrib/backport --continue

[GiteaBot]

I was unable to create a backport for 1.21. @lng2020, please send one manually. 🍵

go run ./contrib/backport 27995
...  // fix git conflicts if any
go run ./contrib/backport --continue