Fix empty action run title #28113
Merged
Fix empty action run title #28113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
delvh
approved these changes
Nov 18, 2023
GiteaBot
added
lgtm/need 1
|
I guess we should make the string translatable. |
github-actions
bot
added
modifies/translation
and removed
modifies/templates
silverwind
reviewed
Nov 20, 2023
wxiaoguang
reviewed
Nov 21, 2023
wxiaoguang
reviewed
Nov 21, 2023
wxiaoguang
approved these changes
Nov 21, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 21, 2023
GiteaBot
added
backport/done
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Nov 21, 2023
silverwind
reviewed
Nov 21, 2023
options/locale/locale_en-US.ini
Outdated
| @@ -3530,7 +3530,7 @@ runs.actors_no_select = All actors | |||
| runs.status_no_select = All status | |||
| runs.no_results = No results matched. | |||
| runs.no_runs = The workflow has no runs yet. | |||
| runs.no_commit_message = empty commit message | |||
| runs.empty_commit_message = empty commit message | |||
There was a problem hiding this comment.
That's not what I meant. Now you have actions.runs.empty_commit_message, but I wanted empty_commit_message because the next time we need this translation outside of actions context, it will be a ugly usage.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 22, 2023
* giteaofficial/main: Fix the description about the default setting for action in quick start document (go-gitea#28160) Do not display search box when there's no packages yet (go-gitea#28146) Add guide page to actions when there's no workflows (go-gitea#28145) Fix no ActionTaskOutput table waring (go-gitea#28149) Fix empty action run title (go-gitea#28113) Use "is-loading" to avoid duplicate form submit for code comment (go-gitea#28143) Fix typo in `packages.cleanup.success` (go-gitea#28133) Add edit option for README.md (go-gitea#28071) Remove autofocus in search box (go-gitea#28033) Add missing `packages.cleanup.success` (go-gitea#28129) Update docs for docusaurus v3 (go-gitea#28125)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27901