Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display search box when there's no packages yet #28146

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Do not display search box when there's no packages yet #28146

merged 2 commits into from
Nov 21, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Nov 21, 2023

Before:
image

After:
image
image
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2023
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Nov 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 21, 2023
@lunny lunny added this to the 1.22.0 milestone Nov 21, 2023
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Nov 21, 2023
@techknowlogick techknowlogick added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2023
@lafriks lafriks enabled auto-merge (squash) November 21, 2023 19:40
@lafriks lafriks merged commit d1acd7e into go-gitea:main Nov 21, 2023
25 checks passed
@GiteaBot GiteaBot mentioned this pull request Nov 21, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 21, 2023
@yp05327 @GiteaBot
Do not display search box when there's no packages yet (go-gitea#28146)
6def173 
Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/3012f544-7ff5-4ccb-ac80-ce24d50abe97)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/4084312a-9ac0-4103-8c93-ea178ae24493)

![image](https://github.com/go-gitea/gitea/assets/18380374/3c47d175-0735-476d-8979-da2bc0a4fc95)

![image](https://github.com/go-gitea/gitea/assets/18380374/033c6a81-d1f7-4426-8063-5793d0b47462)
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 21, 2023
lunny pushed a commit that referenced this pull request Nov 22, 2023
@GiteaBot @yp05327
Do not display search box when there's no packages yet (#28146) (#28159)
7128929 
Backport #28146 by @yp05327

Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/3012f544-7ff5-4ccb-ac80-ce24d50abe97)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/4084312a-9ac0-4103-8c93-ea178ae24493)

![image](https://github.com/go-gitea/gitea/assets/18380374/3c47d175-0735-476d-8979-da2bc0a4fc95)

![image](https://github.com/go-gitea/gitea/assets/18380374/033c6a81-d1f7-4426-8063-5793d0b47462)

Co-authored-by: yp05327 <576951401@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8998dea 
* giteaofficial/main:
  Fix the description about the default setting for action in quick start document (go-gitea#28160)
  Do not display search box when there's no packages yet (go-gitea#28146)
  Add guide page to actions when there's no workflows (go-gitea#28145)
  Fix no ActionTaskOutput table waring (go-gitea#28149)
  Fix empty action run title (go-gitea#28113)
  Use "is-loading" to avoid duplicate form submit for code comment (go-gitea#28143)
  Fix typo in `packages.cleanup.success` (go-gitea#28133)
  Add edit option for README.md (go-gitea#28071)
  Remove autofocus in search box (go-gitea#28033)
  Add missing `packages.cleanup.success` (go-gitea#28129)
  Update docs for docusaurus v3 (go-gitea#28125)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@yp05327 @fuxiaohei
Do not display search box when there's no packages yet (go-gitea#28146)
17185dd 
Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/3012f544-7ff5-4ccb-ac80-ce24d50abe97)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/4084312a-9ac0-4103-8c93-ea178ae24493)

![image](https://github.com/go-gitea/gitea/assets/18380374/3c47d175-0735-476d-8979-da2bc0a4fc95)

![image](https://github.com/go-gitea/gitea/assets/18380374/033c6a81-d1f7-4426-8063-5793d0b47462)
@yp05327 yp05327 deleted the display-searchbox-only-has-packages branch February 1, 2024 00:03
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yp05327 @lunny @delvh @techknowlogick @lafriks @GiteaBot