Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to owner home page in explore #28341

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Dec 4, 2023

User can select access repo or owner's home page.

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2023
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 4, 2023
@fnetX
Copy link
Contributor

fnetX commented Dec 4, 2023

I do think that this potentially leads to confusion. I do not understand the use case for directly clicking on the user instead of having one page in between, but it could potentially lead to many inadvertent clicks especially on short repo names.

Reaching the owner from a repo is easy. The opposite is often not true, especially with custom searches, different filters or a different order.

I think this should be considered from a UX perspective.

@lunny
Copy link
Member

lunny commented Dec 5, 2023

I also think it's unnecessary.

Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see both sides, consistency with the remaining application (a link only links to what is displayed inside it) vs. potential confusion (I'm looking for repos, why am I landing on the user profile?).
Either way, since I don't care for which result we pick, here's my approval pro forma.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 30, 2023
@sonjek
Copy link
Contributor

sonjek commented Jan 4, 2024

Hi, this is a useful improvement because sometimes I have to go to the repository and then to the user's page, which is not convenient. This change will allow to choose where you want to go.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 4, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 5, 2024
@lunny lunny enabled auto-merge (squash) January 5, 2024 03:10
@lunny lunny merged commit dd56933 into go-gitea:main Jan 5, 2024
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Jan 5, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 5, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 5, 2024
* giteaofficial/main:
  Add links to owner home page in explore (go-gitea#28341)
  Apply min-height in wiki only on preview pane (go-gitea#28687)
@yp05327 yp05327 deleted the improve-links-in-explore-repo-list branch February 1, 2024 00:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants