-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to owner home page in explore #28341
Add links to owner home page in explore #28341
Conversation
I do think that this potentially leads to confusion. I do not understand the use case for directly clicking on the user instead of having one page in between, but it could potentially lead to many inadvertent clicks especially on short repo names. Reaching the owner from a repo is easy. The opposite is often not true, especially with custom searches, different filters or a different order. I think this should be considered from a UX perspective. |
I also think it's unnecessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see both sides, consistency with the remaining application (a link only links to what is displayed inside it) vs. potential confusion (I'm looking for repos, why am I landing on the user profile?).
Either way, since I don't care for which result we pick, here's my approval pro forma.
Hi, this is a useful improvement because sometimes I have to go to the repository and then to the user's page, which is not convenient. This change will allow to choose where you want to go. |
* giteaofficial/main: Add links to owner home page in explore (go-gitea#28341) Apply min-height in wiki only on preview pane (go-gitea#28687)
User can select access repo or owner's home page. Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/f40a833f-8560-4585-b047-3a225be2e6ee) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/7893bf3a-5050-4bcb-af99-d56d6c7925f8)
User can select access repo or owner's home page. Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/f40a833f-8560-4585-b047-3a225be2e6ee) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/7893bf3a-5050-4bcb-af99-d56d6c7925f8)
User can select access repo or owner's home page.
Before:
After: