-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Polyfill SubmitEvent for PaleMoon #28441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
155d3d3
to
cb6282e
Compare
Maybe outsource the polyfill to https://github.com/idea2app/event-submitter-polyfill? |
Also, I think we should create a https://github.com/go-gitea/gitea/blob/main/web_src/js/webcomponents/polyfill.js |
No,
No, it's not feasible at the moment. Our polyfill patch needs some dependencies between functions. For example, the |
30ad1e3
to
040a4fa
Compare
040a4fa
to
33a44f8
Compare
Not into |
This polyfill is special, it already "spreads" because there is no transparent approach, the callers have directly dependency with this change. So I do not see it's worth to move the code again. If you have better ideas, feel free to edit this PR directly, I do not see necessary changes at the moment. |
* giteaofficial/main: Polyfill SubmitEvent for PaleMoon (go-gitea#28441) Fix Chinese translation of config cheat sheet[API] (go-gitea#28472) Add combined index for issue_user.uid and issue_id (go-gitea#28080) Fix documents for "custom/public/assets/" (go-gitea#28465) Only use SHA256 feature when git >= 2.42 (go-gitea#28466)
Fix #28319
It only polyfills if there is no "SubmitEvent" class, so it has no side effect for most users.