Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use SHA256 feature when git >= 2.42 #28466

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

wxiaoguang
Copy link
Contributor

And fix some comments

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 14, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Dec 14, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 14, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 14, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 14, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 14, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 14, 2023
@lunny lunny merged commit 9947af6 into go-gitea:main Dec 14, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 14, 2023
@wxiaoguang wxiaoguang deleted the fix-git-object-format branch December 14, 2023 08:59
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 15, 2023
* giteaofficial/main:
  Polyfill SubmitEvent for PaleMoon (go-gitea#28441)
  Fix Chinese translation of config cheat sheet[API] (go-gitea#28472)
  Add combined index for issue_user.uid and issue_id (go-gitea#28080)
  Fix documents for "custom/public/assets/" (go-gitea#28465)
  Only use SHA256 feature when git >= 2.42 (go-gitea#28466)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
AdamMajer pushed a commit to AdamMajer/gitea that referenced this pull request Jan 22, 2024
techknowlogick pushed a commit that referenced this pull request Jan 25, 2024
This should fix #28927

Technically older versions of Git would support this flag as well, but
per #28466 that's the version
where using it (object-format=sha256) left "experimental" state.

`sha1` is (currently) the default, so older clients should be unaffected
in either case.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
henrygoodman pushed a commit to henrygoodman/gitea that referenced this pull request Jan 31, 2024
This should fix go-gitea#28927

Technically older versions of Git would support this flag as well, but
per go-gitea#28466 that's the version
where using it (object-format=sha256) left "experimental" state.

`sha1` is (currently) the default, so older clients should be unaffected
in either case.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
This should fix go-gitea#28927

Technically older versions of Git would support this flag as well, but
per go-gitea#28466 that's the version
where using it (object-format=sha256) left "experimental" state.

`sha1` is (currently) the default, so older clients should be unaffected
in either case.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants