-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate alpine noarch
packages into other architectures index
#29137
Conversation
This is a nice way to fix the issue with noarch packages in the Alpine registry. I used a different approach in Forgejo, based on the information gathered on the official Alpine channels that noarch packages are literally just copied to the available architectures in the repository. However, one issue I had was when I uploaded a noarch package to a repository that doesn't exist. I believe the same issue is present in your PR, if the repo is new and the first package you're uploading is a noarch package, there are no available architectures on the repository and the noarch package won't be copied to the other architectures. The other thing I can say is, while it's nice that you keep track of the noarch packages on a separate "repo", it's not something done by Alpine, since there is no noarch repository on the official registry and apk doesn't support it yet. |
Yes, I know about the problem if there is no other package which provides an architecture. I decided to ignore it because I don't want to set some default architecture which may be correct or incorrect, the system just can't know about it.
Yes, maybe one client does in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typo @KN4CK3R mentioned should be fixed before merging.
Co-authored-by: Lauris BH <lauris@nix.lv>
…CK3R-fix-alpine-noarch
* giteaofficial/main: (45 commits) Include resource state events in Gitlab downloads (go-gitea#29382) Add API to get PR by base/head (go-gitea#29242) [skip ci] Updated translations via Crowdin Improve Documentation for Restoration from backup (go-gitea#29321) Refactor "user/active" related logic (go-gitea#29390) Remove jQuery AJAX from the archive download links (go-gitea#29380) Add tailwindcss (go-gitea#29357) Add missing space (go-gitea#29393) Integrate alpine `noarch` packages into other architectures index (go-gitea#29137) enforce maxlength in frontend (go-gitea#29389) Remove incorrect and unnecessary Escape from templates (go-gitea#29394) Make actions animation rotate counterclockwisely (go-gitea#29378) Use `crypto/sha256` (go-gitea#29386) Add `io.Closer` guidelines (go-gitea#29387) Remove jQuery AJAX from the notice selection deletion button (go-gitea#29381) Refactor Safe modifier (go-gitea#29392) Add attachment support for code review comments (go-gitea#29220) Refactor modules/git global variables (go-gitea#29376) Remove jQuery from the code diff expansion buttons (go-gitea#29385) Remove jQuery AJAX from the markdown editor preview (go-gitea#29384) ...
Fixes #26691
Revert #24972
The alpine package manager expects
noarch
packages in the index of other architectures too.