Add -u git to docs when using docker exec with root installation #29314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
|
isn't that only valid for the rootles containers? |
|
No. The docker exec command is run in the container as the same user that the build the container if no With root image: # id command output when starting the container
$ docker run --entrypoint id gitea/gitea:1.21.5
uid=0(root) gid=0(root) groups=0(root),1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel),11(floppy),20(dialout),26(tape),27(video)
# id command output when execing into an existing container
$ docker exec gitea id
uid=0(root) gid=0(root) groups=0(root),1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel),11(floppy),20(dialout),26(tape),27(video)With rootless image: # id command output when starting the container
$ docker run --entrypoint id gitea/gitea:1.21.5-rootless
uid=1000(git) gid=1000(git) groups=1000(git)
# id command output when execing into an existing container
$ docker exec gitea_rootless id
uid=1000(git) gid=1000(git) groups=1000(git)The only reason the gitea server even starts with the root configuration is because it is run with |
techknowlogick
approved these changes
Apr 3, 2024
GiteaBot
added
lgtm/need 1
techknowlogick
added
backport/v1.20
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 3, 2024
…gitea#29314) This fixes a minor issue in the documentation for SSH Container Passthrough for non-rootless installs. The non-rootless Dockerfile and docker-compose do not set `USER`/`user` instructions so `docker exec` will run as root by default. While running as root, gitea commands will refuse to execute, breaking these approaches. For containers built with the rootless instructions, `docker exec` will run as git by default so this is not necessary in that case. This issue was already discussed in go-gitea#19065, but it does not appear this part of the issue was ever added to the documentation.
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 3, 2024
…gitea#29314) This fixes a minor issue in the documentation for SSH Container Passthrough for non-rootless installs. The non-rootless Dockerfile and docker-compose do not set `USER`/`user` instructions so `docker exec` will run as root by default. While running as root, gitea commands will refuse to execute, breaking these approaches. For containers built with the rootless instructions, `docker exec` will run as git by default so this is not necessary in that case. This issue was already discussed in go-gitea#19065, but it does not appear this part of the issue was ever added to the documentation.
techknowlogick
pushed a commit
that referenced
this pull request
Apr 3, 2024
) (#30258) Backport #29314 by @scribblemaniac This fixes a minor issue in the documentation for SSH Container Passthrough for non-rootless installs. The non-rootless Dockerfile and docker-compose do not set `USER`/`user` instructions so `docker exec` will run as root by default. While running as root, gitea commands will refuse to execute, breaking these approaches. For containers built with the rootless instructions, `docker exec` will run as git by default so this is not necessary in that case. This issue was already discussed in #19065, but it does not appear this part of the issue was ever added to the documentation. Co-authored-by: scribblemaniac <scribblemaniac@users.noreply.github.com>
techknowlogick
pushed a commit
that referenced
this pull request
Apr 3, 2024
) (#30259) Backport #29314 by @scribblemaniac This fixes a minor issue in the documentation for SSH Container Passthrough for non-rootless installs. The non-rootless Dockerfile and docker-compose do not set `USER`/`user` instructions so `docker exec` will run as root by default. While running as root, gitea commands will refuse to execute, breaking these approaches. For containers built with the rootless instructions, `docker exec` will run as git by default so this is not necessary in that case. This issue was already discussed in #19065, but it does not appear this part of the issue was ever added to the documentation. Co-authored-by: scribblemaniac <scribblemaniac@users.noreply.github.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 3, 2024
* giteaofficial/main: Refactor "dump" sub-command (go-gitea#30240) Add -u git to docs when using docker exec with root installation (go-gitea#29314) Show 12 lines in markup code preview (go-gitea#30255) Fixes go-gitea#27605: inline math blocks can't be preceeded/followed by alphanumerical characters (go-gitea#30175) Render embedded code preview by permlink in markdown (go-gitea#30234) Fix missing 0 prefix of GPG key id (go-gitea#30245) Fix spacing in issue navbar (go-gitea#30238) Add unique index for project_issue to prevent duplicate data (go-gitea#30190) [skip ci] Updated translations via Crowdin Refactor commit signature parser (go-gitea#30228) Refactor dropzone (go-gitea#30232) Remove scheduled action tasks if the repo is archived (go-gitea#30224) Refactor file view & render (go-gitea#30227) Refactor DeleteInactiveUsers, fix bug and add tests (go-gitea#30206) [skip ci] Updated licenses and gitignores Add `/options/license` and `/options/gitignore` to `.ignore` (go-gitea#30219)
|
I was unable to create a backport for 1.22. @scribblemaniac, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
lunny
pushed a commit
that referenced
this pull request
Apr 3, 2024
) (#30264) Backport #29314 by @scribblemaniac This fixes a minor issue in the documentation for SSH Container Passthrough for non-rootless installs. The non-rootless Dockerfile and docker-compose do not set `USER`/`user` instructions so `docker exec` will run as root by default. While running as root, gitea commands will refuse to execute, breaking these approaches. For containers built with the rootless instructions, `docker exec` will run as git by default so this is not necessary in that case. This issue was already discussed in #19065, but it does not appear this part of the issue was ever added to the documentation. Co-authored-by: scribblemaniac <scribblemaniac@users.noreply.github.com>
I'm assuming this is a bug with the bot. It appears to have been backported to 1.22 just fine in #30259. |
|
@scribblemaniac yup, all is well, nothing more needed for you to do. Thanks for the PR :) |
AvengerMoJo
pushed a commit
to AvengerMoJo/gitea
that referenced
this pull request
Apr 8, 2024
…gitea#29314) This fixes a minor issue in the documentation for SSH Container Passthrough for non-rootless installs. The non-rootless Dockerfile and docker-compose do not set `USER`/`user` instructions so `docker exec` will run as root by default. While running as root, gitea commands will refuse to execute, breaking these approaches. For containers built with the rootless instructions, `docker exec` will run as git by default so this is not necessary in that case. This issue was already discussed in go-gitea#19065, but it does not appear this part of the issue was ever added to the documentation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue in the documentation for SSH Container Passthrough for non-rootless installs. The non-rootless Dockerfile and docker-compose do not set
USER/userinstructions sodocker execwill run as root by default. While running as root, gitea commands will refuse to execute, breaking these approaches. For containers built with the rootless instructions,docker execwill run as git by default so this is not necessary in that case.This issue was already discussed in #19065, but it does not appear this part of the issue was ever added to the documentation.