Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scheduled action tasks if the repo is archived #30224

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Remove scheduled action tasks if the repo is archived #30224

merged 6 commits into from
Apr 1, 2024

Conversation

Zettat123
Copy link
Contributor

Fix #30220

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 1, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 1, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 1, 2024
@Zettat123 Zettat123 added type/bug topic/gitea-actions related to the actions of Gitea modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code and removed modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 1, 2024
@lunny
Copy link
Member

lunny commented Apr 1, 2024

I don't think it's enough. Maybe we should check whether the repo is archived on the notifier as well.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2024
@Zettat123
Copy link
Contributor Author

I don't think it's enough. Maybe we should check whether the repo is archived on the notifier as well.

Done in 3b174e3

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 1, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2024
@lunny
Copy link
Member

lunny commented Apr 1, 2024

It's better to have some tests.

@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 1, 2024
@lunny lunny enabled auto-merge (squash) April 1, 2024 12:33
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 1, 2024
@lunny lunny merged commit 1ef2eb5 into go-gitea:main Apr 1, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 1, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 1, 2024
@Zettat123 @GiteaBot
Remove scheduled action tasks if the repo is archived (go-gitea#30224)
c2a62c0 
Fix go-gitea#30220
@GiteaBot GiteaBot mentioned this pull request Apr 1, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 1, 2024
silverwind pushed a commit that referenced this pull request Apr 1, 2024
@GiteaBot @Zettat123
Remove scheduled action tasks if the repo is archived (#30224) (#30230)
895d279 
Backport #30224 by @Zettat123

Fix #30220

Co-authored-by: Zettat123 <zettat123@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 3, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ceeb71e 
* giteaofficial/main:
  Refactor "dump" sub-command (go-gitea#30240)
  Add -u git to docs when using docker exec with root installation (go-gitea#29314)
  Show 12 lines in markup code preview (go-gitea#30255)
  Fixes go-gitea#27605: inline math blocks can't be preceeded/followed by alphanumerical characters (go-gitea#30175)
  Render embedded code preview by permlink in markdown (go-gitea#30234)
  Fix missing 0 prefix of GPG key id (go-gitea#30245)
  Fix spacing in issue navbar (go-gitea#30238)
  Add unique index for project_issue to prevent duplicate data (go-gitea#30190)
  [skip ci] Updated translations via Crowdin
  Refactor commit signature parser (go-gitea#30228)
  Refactor dropzone (go-gitea#30232)
  Remove scheduled action tasks if the repo is archived (go-gitea#30224)
  Refactor file view & render (go-gitea#30227)
  Refactor DeleteInactiveUsers, fix bug and add tests (go-gitea#30206)
  [skip ci] Updated licenses and gitignores
  Add `/options/license` and `/options/gitignore` to `.ignore` (go-gitea#30219)
AvengerMoJo pushed a commit to AvengerMoJo/gitea that referenced this pull request Apr 8, 2024
@Zettat123 @AvengerMoJo
Remove scheduled action tasks if the repo is archived (go-gitea#30224)
1f9a5ee 
Fix go-gitea#30220
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Action running in archived repository
6 participants
@Zettat123 @lunny @wolfogre @delvh @wxiaoguang @GiteaBot