Add support for API blob upload of release attachments #29507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
the
modifies/api
|
Ready for review after adding a test. |
delvh
changed the title
delvh
changed the title
delvh
reviewed
Feb 29, 2024
pull-request-size
bot
added
size/L
silverwind
reviewed
Mar 1, 2024
| defer tests.PrintCurrentTest(t)() | ||
|
|
||
| req := NewRequestWithBody(t, http.MethodPost, assetURL, bytes.NewReader(buff.Bytes())). | ||
| AddTokenAuth(token) |
There was a problem hiding this comment.
Suggested change
| AddTokenAuth(token) | |
| AddTokenAuth(token) | |
| SetHeader("Content-Type", "application/octet-stream") |
Just so we test what is specced.
There was a problem hiding this comment.
Use the required Content-Type header to provide the media type of the asset. For a list of media types, see Media Types. For example:
application/zip
That's not specced. The Github docs state that you must pass the content type of the attachment. We do not use the content type, therefore application/octet-stream is not really needed. If we want to make that header required too (even we don't use it), I need to add such a check.
There was a problem hiding this comment.
Right, we accept any content-type except multipart, so it's fine. I suppose GitHub will error when content-type is absent, but we can do that, I see no drawback.
There was a problem hiding this comment.
BTW, with openapi 3.0 or higher, one could do a oneOf check on content-type in the schema validation, but we use swagger 2.0 and it does not support that.
We should eventually migrate to ideally openapi 3.1, but it will require a new validator module.
delvh
approved these changes
Mar 1, 2024
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Mar 2, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
silverwind
approved these changes
Mar 2, 2024
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 3, 2024
* upstream/main: Breaking summary for template refactoring (go-gitea#29395) [skip ci] Updated translations via Crowdin Fix incorrect cookie path for AppSubURL (go-gitea#29534) gitea.service: Remove syslog.target (go-gitea#29550) Add option to set language in admin user view (go-gitea#28449) Fix elipsis button not working if the last commit loading is deferred (go-gitea#29544) Fix incorrect relative/absolute URL usages (go-gitea#29531) Add support for API blob upload of release attachments (go-gitea#29507) Fix queue worker incorrectly stopped when there are still more items in the queue (go-gitea#29532) remove util.OptionalBool and related functions (go-gitea#29513) Rename Action.GetDisplayName to GetActDisplayName (go-gitea#29540) Make PR form use toast to show error message (go-gitea#29545)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29502
Our endpoint is not Github compatible.
https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28#upload-a-release-asset