Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove util.OptionalBool and related functions #29513

Merged
merged 7 commits into from
Mar 2, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 1, 2024

and migrate affected code

last refactoring bits to replace util.OptionalBool with
optional.Option[bool]

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 1, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Mar 1, 2024
@6543 6543 changed the title remove util.OptionalBoolNone and OptionalBool.IsFalse() remove util.OptionalBool and related functions Mar 1, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2024
@6543 6543 requested a review from a team March 1, 2024 15:21
models/actions/runner.go Outdated Show resolved Hide resolved
@6543 6543 requested a review from delvh March 1, 2024 16:28
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2024
@6543 6543 merged commit a3f05d0 into go-gitea:main Mar 2, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Mar 2, 2024
@6543 6543 deleted the rm_OptionalBool_take3 branch March 2, 2024 15:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 3, 2024
* upstream/main:
  Breaking summary for template refactoring (go-gitea#29395)
  [skip ci] Updated translations via Crowdin
  Fix incorrect cookie path for AppSubURL (go-gitea#29534)
  gitea.service: Remove syslog.target (go-gitea#29550)
  Add option to set language in admin user view (go-gitea#28449)
  Fix elipsis button not working if the last commit loading is deferred (go-gitea#29544)
  Fix incorrect relative/absolute URL usages (go-gitea#29531)
  Add support for API blob upload of release attachments (go-gitea#29507)
  Fix queue worker incorrectly stopped when there are still more items in the queue (go-gitea#29532)
  remove util.OptionalBool and related functions (go-gitea#29513)
  Rename Action.GetDisplayName to GetActDisplayName (go-gitea#29540)
  Make PR form use toast to show error message (go-gitea#29545)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants