Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid jQuery .prop and fix related issues #29832

Merged
merged 9 commits into from
Mar 16, 2024
Merged

Forbid jQuery .prop and fix related issues #29832

merged 9 commits into from
Mar 16, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 16, 2024 •
edited
Loading

The issue checkbox code received a few more cleanups and I specifically tested it. The other changes are trivial. Also, I checked the cases for how many elements match the jQuery selection to determine querySelector vs. querySelectorAll.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 16, 2024
@silverwind silverwind changed the title Forbide jQuery .prop and fix related issues Forbide jQuery .prop and fix related issues Mar 16, 2024
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed modifies/frontend modifies/internal modifies/js labels Mar 16, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2024
@silverwind silverwind changed the title Forbide jQuery .prop and fix related issues Forbid jQuery .prop and fix related issues Mar 16, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2024
@silverwind silverwind enabled auto-merge (squash) March 16, 2024 12:32
@silverwind
Copy link
Member Author

Seems I missed some:

/home/runner/work/gitea/gitea/web_src/js/features/comp/LabelEdit.js
  17:9  error  Prefer direct property access to $.prop        jquery/no-prop
  17:9  error  Prefer direct property access to .prop/$.prop  no-jquery/no-prop
  53:5  error  Prefer direct property access to $.prop        jquery/no-prop
  53:5  error  Prefer direct property access to .prop/$.prop  no-jquery/no-prop
  56:5  error  Prefer direct property access to $.prop        jquery/no-prop
  56:5  error  Prefer direct property access to .prop/$.prop  no-jquery/no-prop

@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2024
@silverwind
Copy link
Member Author

Ah, it seems the change done in 3cd6494 made the linter detect these new cases.

@silverwind
Copy link
Member Author

Fixed in c14b370.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2024
@silverwind silverwind enabled auto-merge (squash) March 16, 2024 13:09
@silverwind
Copy link
Member Author

another new lint failure has appeared, seems related to #29843.

/home/runner/work/gitea/gitea/web_src/js/features/repo-issue-list.js
  33:5  error  Avoid injection of possibly unescaped HTML. Create DOM elements instead, or use .text  no-jquery/no-append-html

@silverwind
Copy link
Member Author

Fixed in 8d434a2 and tested as well.

@silverwind silverwind merged commit 21fe512 into go-gitea:main Mar 16, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 16, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2024
@silverwind silverwind deleted the noprop branch March 16, 2024 15:18
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
49462d6 
* giteaofficial/main: (28 commits)
  Forbid jQuery `.prop` and fix related issues (go-gitea#29832)
  Fix wrong test for TestPullView_CodeOwner (go-gitea#29838)
  Forbid HTML injection using jQuery (go-gitea#29843)
  Meilisearch double quote on "match" query (go-gitea#29740)
  Forbid variables containing jQuery collections not having the `$` prefix (go-gitea#29839)
  Remove AddParamIfExist(AddParam) (go-gitea#29841)
  Refactor markdown attention render (go-gitea#29833)
  Refactor code_indexer to use an SearchOptions struct for PerformSearch (go-gitea#29724)
  Refactor AddParam to AddParamIfExist (go-gitea#29834)
  Forbid jQuery AJAX (go-gitea#29818)
  Remove jQuery AJAX from the notifications (go-gitea#29817)
  Light theme color enhancements (go-gitea#29830)
  Better highlighting of archved labels (go-gitea#29749)
  Remove the `time-since` class (go-gitea#29826)
  Remove jQuery AJAX from the project page (go-gitea#29814)
  Upgrade `htmx` to v1.9.11 (go-gitea#29821)
  Dark theme color enhancements (go-gitea#29822)
  Remove jQuery AJAX from the comment edit box (go-gitea#29812)
  Tweak labeler (go-gitea#29809)
  Fix `for` attribute not pointing to the ID of the color picker (go-gitea#29813)
  ...

# Conflicts:
#	routers/web/user/home.go
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 22, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @lunny @wxiaoguang @yardenshoham @GiteaBot