Forbid HTML injection using jQuery #29843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/wikimedia/eslint-plugin-no-jquery/blob/master/docs/rules/no-append-html.md Tested the following components and they work as before: - notification table - issue author dropdown - comment edit box attachments div Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
yardenshoham
added
the
type/refactoring
lunny
approved these changes
Mar 16, 2024
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Mar 16, 2024
silverwind
approved these changes
Mar 16, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 16, 2024
* giteaofficial/main: (28 commits) Forbid jQuery `.prop` and fix related issues (go-gitea#29832) Fix wrong test for TestPullView_CodeOwner (go-gitea#29838) Forbid HTML injection using jQuery (go-gitea#29843) Meilisearch double quote on "match" query (go-gitea#29740) Forbid variables containing jQuery collections not having the `$` prefix (go-gitea#29839) Remove AddParamIfExist(AddParam) (go-gitea#29841) Refactor markdown attention render (go-gitea#29833) Refactor code_indexer to use an SearchOptions struct for PerformSearch (go-gitea#29724) Refactor AddParam to AddParamIfExist (go-gitea#29834) Forbid jQuery AJAX (go-gitea#29818) Remove jQuery AJAX from the notifications (go-gitea#29817) Light theme color enhancements (go-gitea#29830) Better highlighting of archved labels (go-gitea#29749) Remove the `time-since` class (go-gitea#29826) Remove jQuery AJAX from the project page (go-gitea#29814) Upgrade `htmx` to v1.9.11 (go-gitea#29821) Dark theme color enhancements (go-gitea#29822) Remove jQuery AJAX from the comment edit box (go-gitea#29812) Tweak labeler (go-gitea#29809) Fix `for` attribute not pointing to the ID of the color picker (go-gitea#29813) ... # Conflicts: # routers/web/user/home.go
|
-> Edit comment bug #29986
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/wikimedia/eslint-plugin-no-jquery/blob/master/docs/rules/no-append-html.md
Tested the following components and they work as before: