Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #27605: inline math blocks can't be preceeded/followed by alphanumerical characters (#30175) #30250

Merged

Commits on Apr 2, 2024

  1. Fixes go-gitea#27605: inline math blocks can't be preceeded/followed …

    …by alphanumerical characters (go-gitea#30175)
    
    - Inline math blocks couldn't be preceeded or succeeded by
    alphanumerical characters due to changes introduced in PR go-gitea#21171.
    Removed the condition that caused this (precedingCharacter condition)
    and added a new exit condition of the for-loop that checks if a specific
    '$' was escaped using '\' so that the math expression can be rendered as
    intended.
    - Additionally this PR fixes another bug where math blocks of the type
    '$xyz$abc$' where the dollar sign was not escaped by the user, generated
    an error (shown in the screenshots below)
    - Altered the tests to accomodate for the changes
    
    Former behaviour (from try.gitea.io):
    
    ![image](https://github.com/go-gitea/gitea/assets/114936010/8f0cbb21-321d-451c-b871-c67a8e1e9235)
    
    Fixed behaviour (from my local build):
    
    ![image](https://github.com/go-gitea/gitea/assets/114936010/5c22687c-6f11-4407-b5e7-c14b838bc20d)
    
    (Edit) Source code for the README.md file:
    ```
    $x$ -$x$ $x$-
    
    a$xa$ $xa$a 1$xb$ $xb$1
    
    $a a$b b$
    
    a$b $a a$b b$
    
    $a a\$b b$
    ```
    
    ---------
    
    Signed-off-by: João Tiago <joao.leal.tintas@tecnico.ulisboa.pt>
    Co-authored-by: Giteabot <teabot@gitea.io>
    jmlt2002 and GiteaBot committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9bf4a57 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Configuration menu
    Copy the full SHA
    e5e45c0 View commit details
    Browse the repository at this point in the history