-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports forced use of S3 virtual-hosted style #30969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Could you also add the new config option to the docs (and app.ini example)? I'm on mobile, but if you need help finding where to add documentation for this please let me know and I can send a link when I'm at my computer:)
Okay, I added it to the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Unit test failure looks related:
|
Ah, yeah that's my bad. |
gitea/modules/storage/minio_test.go Lines 23 to 30 in db57843
It seems that the unit test directly assigns values to the minio configuration without going through the logic of assigning default values. |
* giteaofficial/main: Put web editor into a segment (go-gitea#30966) Check if the release is converted from the tag when updating the release (go-gitea#30984) Supports forced use of S3 virtual-hosted style (go-gitea#30969)
Add a configuration item to enable S3 virtual-hosted style (V2) to solve the problem caused by some S3 service providers not supporting path style (V1).
Resolves #14991