Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the release is converted from the tag when updating the release #30984

Merged
merged 2 commits into from
May 15, 2024
Merged

Check if the release is converted from the tag when updating the release #30984

merged 2 commits into from
May 15, 2024

Conversation

Zettat123
Copy link
Contributor

Fix #30619

We should call notify_service.NewRelease when a release is created from an existing tag.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 15, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 15, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 15, 2024
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 15, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 15, 2024
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 15, 2024
@jolheiser jolheiser enabled auto-merge (squash) May 15, 2024 14:00
@jolheiser jolheiser merged commit fc89363 into go-gitea:main May 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 15, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 15, 2024
@Zettat123 @GiteaBot
Check if the release is converted from the tag when updating the rele…
873cf6c 
…ase (go-gitea#30984)

Call `notify_service.NewRelease` when a release is created
from an existing tag.
@GiteaBot GiteaBot mentioned this pull request May 15, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 15, 2024
jolheiser pushed a commit that referenced this pull request May 15, 2024
@GiteaBot @Zettat123
Check if the release is converted from the tag when updating the rele…
0c9dcda 
…ase (#30984) (#30986)

We should call `notify_service.NewRelease` when a release is created
from an existing tag.

Co-authored-by: Zettat123 <zettat123@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
4d0309f 
* giteaofficial/main:
  Put web editor into a segment (go-gitea#30966)
  Check if the release is converted from the tag when updating the release (go-gitea#30984)
  Supports forced use of S3 virtual-hosted style (go-gitea#30969)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Release created from an existing tag does not trigger an actions workflow
4 participants
@Zettat123 @silverwind @jolheiser @GiteaBot