Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll to issue sidebar dropdowns #31597

Closed
wants to merge 4 commits into from
Closed

Add scroll to issue sidebar dropdowns #31597

wants to merge 4 commits into from

Conversation

a1012112796
Copy link
Member

as title, fix #31589

examples:
屏幕截图 2024-07-09 110007

屏幕截图 2024-07-09 105146

屏幕截图 2024-07-09 102303

屏幕截图 2024-07-09 101441

屏幕截图 2024-07-09 100859

@a1012112796
Add scroll to issue sidebar dropdowns
c5834ce 
as title, fix go-gitea#31589

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jul 9, 2024
@a1012112796
fix lint
6c6f252 
Signed-off-by: a1012112796 <1012112796@qq.com>
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jul 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 11, 2024
@lunny
Copy link
Member

lunny commented Aug 12, 2024

It's better to use Vue rather than Go template there if you would like to do a refactor. Because they should be refactored to an instance UI in the future. So we don't need to do it twice.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 13, 2024 •
edited
Loading

  1. It could only use tmpl at the moment, but not Vue
  2. Some changes don't seem proper. For example: why using no-select? It has other meanings in code, and shouldn't be used as a new purpose.
  3. I guess you mean const $menu = $(`${select_id} > .menu`), but not use more :not filters.

@wxiaoguang
Copy link
Contributor

  1. Be careful of conflicts with Support issue template assignees #31083 , do not lose changes from it

@wxiaoguang
Copy link
Contributor

This change doesn't seem good enough.

I have refactored the sidebar dropdowns, please follow the new "combo dropdown list" to add new enhancements to them.

Refactor sidebar label selector #32460

@a1012112796 a1012112796 deleted the zzc/dev/issue_sidebar branch November 11, 2024 08:41
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Nov 20, 2024
@a1012112796
make search box in issue sidebar dropdown list always at head when sc…
79ba2c5 
…rolling

as title, replace go-gitea#31597 after go-gitea#32460

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 mentioned this pull request Nov 20, 2024
Merged
wxiaoguang pushed a commit that referenced this pull request Nov 21, 2024
@a1012112796
make search box in issue sidebar dropdown list always show when scrol…
23d0f90 
…ling (#32576)

as title, replace #31597 after #32460 

---------

Signed-off-by: a1012112796 <1012112796@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add scroll to dropdowns
6 participants
@a1012112796 @lunny @wxiaoguang @6543 @techknowlogick @GiteaBot