-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make search box in issue sidebar dropdown list always show when scrolling #32576
Merged
wxiaoguang
merged 3 commits into
go-gitea:main
from
a1012112796:zzc/dev/issue_sidebar_ui
Nov 21, 2024
Merged
make search box in issue sidebar dropdown list always show when scrolling #32576
wxiaoguang
merged 3 commits into
go-gitea:main
from
a1012112796:zzc/dev/issue_sidebar_ui
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rolling as title, replace go-gitea#31597 after go-gitea#32460 Signed-off-by: a1012112796 <1012112796@qq.com>
Signed-off-by: a1012112796 <1012112796@qq.com>
wxiaoguang
reviewed
Nov 20, 2024
wxiaoguang
approved these changes
Nov 20, 2024
delvh
approved these changes
Nov 20, 2024
The scrolling menu has border, also need this: Improve issue sidebar UI #32587 |
Need to fix: Fix issue sidebar regression #32598 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 22, 2024
* giteaofficial/main: Add line-through for deleted branch on pull request view page (go-gitea#32500) Fix issue sidebar regression (go-gitea#32598) Fix PR diff review form submit (go-gitea#32596) Fix some typescript issues (go-gitea#32586) Fix GetInactiveUsers (go-gitea#32540) disable gravatar in test (go-gitea#32529) Add 'Copy path' button to file view (go-gitea#32584) Improve issue sidebar UI (go-gitea#32587) Supplement and Improvement for go-gitea#32558 (go-gitea#32585) make search box in issue sidebar dropdown list always show when scrolling (go-gitea#32576) Fix submodule parsing (go-gitea#32571) allow the actions user to login via the jwt token (go-gitea#32527) Support HTTP POST requests to `/userinfo`, aligning to OpenID Core specification (go-gitea#32578)
It seems that there is another regression, the dropdown loses keyboard support ArrowUp/ArrowDown/Enter doesn't work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/templates
This PR modifies the template files
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title, replace #31597 after #32460, examples: