Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make search box in issue sidebar dropdown list always show when scrolling #32576

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Nov 20, 2024

as title, replace #31597 after #32460, examples:

image


image

屏幕截图 2024-11-20 181852

…rolling

as title, replace go-gitea#31597 after go-gitea#32460

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Nov 20, 2024
@a1012112796 a1012112796 changed the title make search box in issue sidebar dropdown list always at head when scrolling make search box in issue sidebar dropdown list always show when scrolling Nov 20, 2024
Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 20, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2024
@wxiaoguang wxiaoguang merged commit 23d0f90 into go-gitea:main Nov 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 21, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2024
@wxiaoguang
Copy link
Contributor

The scrolling menu has border, also need this: Improve issue sidebar UI #32587

@lunny lunny modified the milestones: 1.24.0, 1.23.0 Nov 21, 2024
@wxiaoguang
Copy link
Contributor

Need to fix: Fix issue sidebar regression #32598

zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2024
* giteaofficial/main:
  Add line-through for deleted branch on pull request view page (go-gitea#32500)
  Fix issue sidebar regression (go-gitea#32598)
  Fix PR diff review form submit (go-gitea#32596)
  Fix some typescript issues (go-gitea#32586)
  Fix GetInactiveUsers (go-gitea#32540)
  disable gravatar in test (go-gitea#32529)
  Add 'Copy path' button to file view (go-gitea#32584)
  Improve issue sidebar UI (go-gitea#32587)
  Supplement and Improvement for go-gitea#32558 (go-gitea#32585)
  make search box in issue sidebar dropdown list always show when scrolling (go-gitea#32576)
  Fix submodule parsing (go-gitea#32571)
  allow the actions user to login via the jwt token (go-gitea#32527)
  Support HTTP POST requests to `/userinfo`, aligning to OpenID Core specification (go-gitea#32578)
@wxiaoguang
Copy link
Contributor

It seems that there is another regression, the dropdown loses keyboard support

ArrowUp/ArrowDown/Enter doesn't work.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants