Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement GetUserOrgsList to make it simple and clear #32486

Merged
merged 10 commits into from
Nov 14, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 12, 2024

Reimplement GetUserOrgsList and also move some functions and test to org_list file.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 12, 2024
@lunny lunny force-pushed the lunny/reimplement_GetUserOrgsLit branch from d2554f2 to 1a152ad Compare November 13, 2024 03:29
models/organization/org_list.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 14, 2024
Co-authored-by: Zettat123 <zettat123@gmail.com>
@lunny lunny added this to the 1.23.0 milestone Nov 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 14, 2024
@lunny lunny enabled auto-merge (squash) November 14, 2024 04:05
@lunny lunny merged commit b4abb6d into go-gitea:main Nov 14, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 14, 2024
@lunny lunny deleted the lunny/reimplement_GetUserOrgsLit branch November 14, 2024 06:39
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 15, 2024
* giteaofficial/main:
  Fix oauth2 error handle not return immediately (go-gitea#32514)
  Fix incorrect project page CSS class (go-gitea#32510)
  Add avif image file support (go-gitea#32508)
  Reduce integration test overhead (go-gitea#32475)
  Remove jQuery import from some files (go-gitea#32512)
  Trim title before insert/update to database to match the size requirements of database (go-gitea#32498)
  Reimplement GetUserOrgsList to make it simple and clear (go-gitea#32486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants