Fix incorrect project page CSS class #32510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
wxiaoguang
added
type/bug
skip-changelog
github-actions
bot
added
the
modifies/templates
silverwind
approved these changes
Nov 14, 2024
GiteaBot
added
the
lgtm/need 1
Hopefully so. Otherwise, the JS error happens in Before there was no problem because old code used jQuery, it ignored non-existing elements. But new code uses JS DOM, then the wrong CSS class causes wrong code execution. Indeed, the CSS class is wrong, it shouldn't be there. |
lunny
approved these changes
Nov 14, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
pull-request-size
bot
added
the
size/XS
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 15, 2024
* giteaofficial/main: Fix oauth2 error handle not return immediately (go-gitea#32514) Fix incorrect project page CSS class (go-gitea#32510) Add avif image file support (go-gitea#32508) Reduce integration test overhead (go-gitea#32475) Remove jQuery import from some files (go-gitea#32512) Trim title before insert/update to database to match the size requirements of database (go-gitea#32498) Reimplement GetUserOrgsList to make it simple and clear (go-gitea#32486)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise milestone JS would run on this page and cause errors