Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue of Review Menu Shown Behind #32631

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Fixed Issue of Review Menu Shown Behind #32631

merged 6 commits into from
Nov 26, 2024

Conversation

kerwin612
Copy link
Member

Fixed #31144
054c7719ce64acf22e0b0aecba4910f

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Nov 25, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 25, 2024
wxiaoguang
wxiaoguang previously requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think the new JS code is right or maintainable.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 25, 2024
@wxiaoguang
Copy link
Contributor

And there is a regression bug from Simplify review UI #31062 , the dropdown doesn't get properly initialized when "show more files"

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Nov 25, 2024
@wxiaoguang
Copy link
Contributor

Overall it should be like this 1957c87

@wxiaoguang wxiaoguang mentioned this pull request Nov 25, 2024
Merged
@kerwin612 kerwin612 requested a review from wxiaoguang November 25, 2024 05:53
@kerwin612
Copy link
Member Author

9faaa40

before:
ac67f50ea3444a00d0754c4c468825e

after:
013de5209d4d598acbe4f764124aa5d

wxiaoguang
wxiaoguang reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess some tests need to be fixed too

@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 25, 2024
@kerwin612 kerwin612 requested a review from wxiaoguang November 25, 2024 15:29
@kerwin612 kerwin612 added this to the 1.23.0 milestone Nov 26, 2024
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 26, 2024
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 26, 2024
@wxiaoguang wxiaoguang merged commit 25cacaf into go-gitea:main Nov 26, 2024
26 checks passed
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 26, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
71463b8 
* giteaofficial/main:
  Introduce OrgList and add LoadTeams, optimaze Load teams for orgs (go-gitea#32543)
  Refactor markup render system (go-gitea#32645)
  Fix: passkey login not working anymore (go-gitea#32623)
  Refactor some frontend problems (go-gitea#32646)
  Bypass vitest bug (go-gitea#32647)
  Fix race condition in mermaid observer (go-gitea#32599)
  Improve oauth2 scope token handling (go-gitea#32633)
  Fixed Issue of Review Menu Shown Behind (go-gitea#32631)
  Add github compatible tarball download API endpoints (go-gitea#32572)
  Fix markup render regression and fix some tests (go-gitea#32640)
  Fix sqlite3 test (go-gitea#32622)
  Strict pagination check (go-gitea#32548)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 24, 2025
@kerwin612 kerwin612 deleted the patch-23 branch March 5, 2025 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Review Menu Shown Behind
4 participants
@kerwin612 @wxiaoguang @lunny @GiteaBot