Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some frontend problems #32646

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 26, 2024

  1. correct the modal usage on "admin email list" page (then web_src/js/features/admin/emails.ts is removed)
  2. use addDelegatedEventListener instead of jQuery().on
  3. more jQuery related changes and remove jQuery from web_src/js/features/common-button.ts
  4. improve confirmModal to make it support header, and remove incorrect double-escaping
  5. fix more typescript related types
  6. fine tune devtest pages and add more tests

screenshots (the modal dialog is slightly different due to a legacy "form content" problem, see devtest/modal comments)

image

image

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Nov 26, 2024
@wxiaoguang wxiaoguang force-pushed the refactor-common-button branch from 31f104b to a424b89 Compare November 26, 2024 13:25
@wxiaoguang wxiaoguang force-pushed the refactor-common-button branch from a424b89 to fd42259 Compare November 26, 2024 13:45
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golang code / templates & functionality confirmed

and we finaly got rid of jquery on common-button

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 26, 2024 15:16
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 26, 2024
@wxiaoguang wxiaoguang merged commit 0f4b0cf into go-gitea:main Nov 26, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 26, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 26, 2024
@wxiaoguang wxiaoguang deleted the refactor-common-button branch November 26, 2024 15:54
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 27, 2024
* giteaofficial/main:
  Introduce OrgList and add LoadTeams, optimaze Load teams for orgs (go-gitea#32543)
  Refactor markup render system (go-gitea#32645)
  Fix: passkey login not working anymore (go-gitea#32623)
  Refactor some frontend problems (go-gitea#32646)
  Bypass vitest bug (go-gitea#32647)
  Fix race condition in mermaid observer (go-gitea#32599)
  Improve oauth2 scope token handling (go-gitea#32633)
  Fixed Issue of Review Menu Shown Behind (go-gitea#32631)
  Add github compatible tarball download API endpoints (go-gitea#32572)
  Fix markup render regression and fix some tests (go-gitea#32640)
  Fix sqlite3 test (go-gitea#32622)
  Strict pagination check (go-gitea#32548)
@wxiaoguang
Copy link
Contributor Author

Sorry for bothering, need to fix a regression: Fix global form submit event #32652 (my copy&paste mistake)

@lunny lunny modified the milestones: 1.24.0, 1.23.0 Nov 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants