-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor some frontend problems #32646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31f104b
to
a424b89
Compare
a424b89
to
fd42259
Compare
6543
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golang code / templates & functionality confirmed
and we finaly got rid of jquery on common-button
kerwin612
approved these changes
Nov 26, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 27, 2024
* giteaofficial/main: Introduce OrgList and add LoadTeams, optimaze Load teams for orgs (go-gitea#32543) Refactor markup render system (go-gitea#32645) Fix: passkey login not working anymore (go-gitea#32623) Refactor some frontend problems (go-gitea#32646) Bypass vitest bug (go-gitea#32647) Fix race condition in mermaid observer (go-gitea#32599) Improve oauth2 scope token handling (go-gitea#32633) Fixed Issue of Review Menu Shown Behind (go-gitea#32631) Add github compatible tarball download API endpoints (go-gitea#32572) Fix markup render regression and fix some tests (go-gitea#32640) Fix sqlite3 test (go-gitea#32622) Strict pagination check (go-gitea#32548)
Sorry for bothering, need to fix a regression: Fix global form submit event #32652 (my copy&paste mistake) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/frontend
modifies/go
Pull requests that update Go code
modifies/templates
This PR modifies the template files
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web_src/js/features/admin/emails.ts
is removed)addDelegatedEventListener
instead ofjQuery().on
web_src/js/features/common-button.ts
confirmModal
to make it support header, and remove incorrect double-escapingscreenshots (the modal dialog is slightly different due to a legacy "form content" problem, see devtest/modal comments)