Refactor markdown editor and use it for milestone description editor #32688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/go
6 tasks
wxiaoguang
force-pushed
the
fix-markdown-editor
branch
2 times, most recently
from
4bb968e to
c251dc9
Compare
wxiaoguang
force-pushed
the
fix-markdown-editor
branch
from
c251dc9 to
f0e2876
Compare
silverwind
reviewed
Dec 2, 2024
silverwind
reviewed
Dec 2, 2024
silverwind
reviewed
Dec 2, 2024
lunny
approved these changes
Dec 2, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
commented
Dec 3, 2024
silverwind
reviewed
Dec 3, 2024
silverwind
reviewed
Dec 3, 2024
GiteaBot
added
lgtm/blocked
Do you have a estimated time? If no time in 1 or 2 days, we can merge it as-is and there are always chances to propose following PRs. |
|
Done now. This one-pair-per line style is much more readable and I really wonder why you would consider not honoring it. |
silverwind
approved these changes
Dec 4, 2024
GiteaBot
added
lgtm/done
It is less readable to me. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 4, 2024
* giteaofficial/main: Fix delete branch perm checking (go-gitea#32654) Refactor markdown editor and use it for milestone description editor (go-gitea#32688) Fix issue title rendering and refactor legacy function names (go-gitea#32703) Fix oauth2 login methods (go-gitea#32698) Fix word overflow in file search page (go-gitea#32695) Add Swift login endpoint (go-gitea#32693) Quick fix for license file name (go-gitea#32696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor markdown editor to clarify its "preview" behavior and remove jQuery code.
Close #15045
Manually tested related pages:
project (repo-level)
project (org-level)
PR review approve comment
PR review diff comment (new, edit)
issue description (new, edit)
issue comment (new, edit)
issue template editor
milestone
release
wiki
by the way, fix UI misalignment: