Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Swift login endpoint #32693

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Add Swift login endpoint #32693

merged 4 commits into from
Dec 3, 2024

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 2, 2024

Fix #32683

This PR adds the login endpoint and fixes the documentation links.

@KN4CK3R
Add login endpoint.
b26d471 
Fix documentation links.
@KN4CK3R KN4CK3R added type/enhancement An improvement of existing functionality topic/packages labels Dec 2, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 2, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 2, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2024
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Dec 2, 2024

Added the /login endpoint too. This endpoint was not triggered in my tests some minutes ago but may still be used according to the code:
https://github.com/swiftlang/swift-package-manager/blob/5525fffe9308cf7e5ea8949fa9ae9a60b3f9a77f/Sources/PackageRegistryCommand/PackageRegistryCommand%2BAuth.swift#L103

wxiaoguang
wxiaoguang approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that sooner or later, we need to split the function code out from the "api.go", to make the router init function tiny and clear.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2024
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. backport/v1.22 This PR should be backported to Gitea 1.22 labels Dec 2, 2024
@lunny lunny added this to the 1.23.0 milestone Dec 2, 2024
@lunny lunny enabled auto-merge (squash) December 2, 2024 23:19
@lunny lunny merged commit 1364083 into go-gitea:main Dec 3, 2024
26 checks passed
@GiteaBot
Copy link
Collaborator

GiteaBot commented Dec 3, 2024

I was unable to create a backport for 1.22. @KN4CK3R, please send one manually. 🍵

go run ./contrib/backport 32693
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 3, 2024
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Dec 3, 2024
@KN4CK3R
Add Swift login endpoint (go-gitea#32693)
5a92355 
Fix go-gitea#32683

This PR adds the login endpoint and fixes the documentation links.
@KN4CK3R KN4CK3R mentioned this pull request Dec 3, 2024
Merged
@KN4CK3R KN4CK3R deleted the enhancement-swift-login branch December 3, 2024 19:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 4, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c87deba 
* giteaofficial/main:
  Fix delete branch perm checking (go-gitea#32654)
  Refactor markdown editor and use it for milestone description editor (go-gitea#32688)
  Fix issue title rendering and refactor legacy function names (go-gitea#32703)
  Fix oauth2 login methods (go-gitea#32698)
  Fix word overflow in file search page (go-gitea#32695)
  Add Swift login endpoint (go-gitea#32693)
  Quick fix for license file name (go-gitea#32696)
techknowlogick pushed a commit that referenced this pull request Dec 5, 2024
@KN4CK3R
Add Swift login endpoint (#32693) (#32701)
0c4c28b 
Backport of #32693

Fix #32683

This PR adds the login endpoint and fixes the documentation links.
@lunny lunny added the backport/done All backports for this PR have been created label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiifong hiifong hiifong left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/packages type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

login to swift package has error
6 participants
@KN4CK3R @GiteaBot @wxiaoguang @delvh @hiifong @lunny