Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of typescript errors #32773

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 9, 2024

Fixes 96 typescript errors. Behaviour changes are commented below.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 9, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2024
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 9, 2024
@wxiaoguang

This comment was marked as outdated.

* origin/main:
  Fix internal server error when updating labels without write permission (go-gitea#32776)
  Fix wiki ui (go-gitea#32781)
  Change typescript `module` to `nodenext` (go-gitea#32757)
  Refactor issue filter (labels, poster, assignee) (go-gitea#32771)
  Make RepoActionView.vue support `##[group]` (go-gitea#32770)
  [skip ci] Updated translations via Crowdin
@silverwind
Copy link
Member Author

Merge was easy, only one small conflict because of the removed function.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2024
@silverwind silverwind merged commit 8a53a39 into go-gitea:main Dec 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 11, 2024
@silverwind silverwind deleted the types-8 branch December 11, 2024 08:29
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Dec 11, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2024
* giteaofficial/main:
  Switch to `eslint-plugin-import-x` (go-gitea#32790)
  Fix clone panel js error (go-gitea#32798)
  [skip ci] Updated translations via Crowdin
  Add `is_archived` option for issue indexer (go-gitea#32735)
  Upgrade dependency crypto library (go-gitea#32750)
  Add standard-compliant route to serve outdated R packages (go-gitea#32783)
  Fix repo home file list (go-gitea#32788)
  Rearrange Clone Panel (go-gitea#31142)
  Fix a number of typescript errors (go-gitea#32773)
  Add label/author/assignee filters to the user/org home issue list (go-gitea#32779)

# Conflicts:
#	templates/repo/wiki/revision.tmpl
#	templates/repo/wiki/view.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants