Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move eslint config to javascript #32869

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Move eslint config to javascript #32869

merged 4 commits into from
Dec 18, 2024

Conversation

silverwind
Copy link
Member

In preparation for migrating to eslint flat config, move the config file to javascript. Additional changes:

  • no-undef is now disabled as it's no longer needed with typescript
  • no-restricted-globals config is simplified

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 17, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 17, 2024
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 17, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 17, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 17, 2024
@lunny lunny enabled auto-merge (squash) December 17, 2024 22:54
@lunny lunny merged commit 195fccd into go-gitea:main Dec 18, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 18, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 18, 2024
@silverwind silverwind deleted the esjs branch December 18, 2024 07:42
@wxiaoguang wxiaoguang mentioned this pull request Dec 27, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Fix eslint #33002

wxiaoguang added a commit that referenced this pull request Dec 27, 2024
@wxiaoguang
Fix eslint (#33002)
ea198f9 
Fix  #32982
Related #32869

* eslint-plugin-github 5.1.x doesn't work well with eslint8
* no-undef is still needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@silverwind @wxiaoguang @lunny @yardenshoham @delvh @GiteaBot