Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commit status when changing labels #33116

Closed
wants to merge 1 commit into from
Closed

Update commit status when changing labels #33116

wants to merge 1 commit into from

Conversation

Zettat123
Copy link
Contributor

Fix #33051

Should we support all the pull_request related events?

gitea/modules/actions/workflows.go

Lines 220 to 226 in 3c1c508

case // pull_request
webhook_module.HookEventPullRequest,
webhook_module.HookEventPullRequestSync,
webhook_module.HookEventPullRequestAssign,
webhook_module.HookEventPullRequestLabel,
webhook_module.HookEventPullRequestReviewRequest,
webhook_module.HookEventPullRequestMilestone:

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 6, 2025
@yp05327
Copy link
Contributor

yp05327 commented Jan 6, 2025 •
edited
Loading

I was just editing the PR...
yp05327@ad24940
I suggest add all of them. Not adding them one by one.
Also considering add the test later...

@Zettat123
Copy link
Contributor Author

Zettat123 commented Jan 6, 2025 •
edited
Loading

I was just editing the PR... yp05327@ad24940 I suggest add all of them. Not adding them one by one. Also considering add the test later...

Thanks! I'd like to close this PR and wait for yours.

@Zettat123 Zettat123 closed this Jan 6, 2025
@yp05327 yp05327 mentioned this pull request Jan 6, 2025
Merged
1 task
lunny pushed a commit that referenced this pull request Jan 7, 2025
@yp05327
Update status check for all supported on.pull_request.types in Gitea (#…
32d45ee 
…33117)

Thanks @Zettat123
Follow #33116
Fix #33051

on.pull_request.types doc:

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

on.pull_request.types added in this PR:
```
assigned, unassigned, review_requested, review_request_removed, milestoned, demilestoned, labeled, unlabeled
```

unsupported types in Gitea:
```
// Unsupported activity types:
// converted_to_draft, ready_for_review, locked, unlocked, auto_merge_enabled, auto_merge_disabled, enqueued, dequeued
```

TODO:
- [x] add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Status Check on Event
4 participants
@Zettat123 @yp05327 @wxiaoguang @GiteaBot