Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update status check for all supported on.pull_request.types in Gitea #33117

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Update status check for all supported on.pull_request.types in Gitea #33117

merged 6 commits into from
Jan 7, 2025

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jan 6, 2025 •
edited
Loading

Thanks @Zettat123
Follow #33116
Fix #33051

on.pull_request.types doc:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request

on.pull_request.types added in this PR:

assigned, unassigned, review_requested, review_request_removed, milestoned, demilestoned, labeled, unlabeled

unsupported types in Gitea:

// Unsupported activity types:
// converted_to_draft, ready_for_review, locked, unlocked, auto_merge_enabled, auto_merge_disabled, enqueued, dequeued

TODO:

  • add test

⚠️This PR refuses to be cherry-picked by any forked projects without any mentions.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 6, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 6, 2025
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2025
@lunny lunny requested a review from Zettat123 January 7, 2025 00:41
Zettat123
Zettat123 approved these changes Jan 7, 2025
View reviewed changes
tests/integration/actions_trigger_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 7, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2025
@lunny lunny added this to the 1.24.0 milestone Jan 7, 2025
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. type/enhancement An improvement of existing functionality labels Jan 7, 2025
@lunny lunny merged commit 32d45ee into go-gitea:main Jan 7, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 7, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 8, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b2c0630 
* giteaofficial/main:
  add submodule diff links (go-gitea#33097)
  [skip ci] Updated translations via Crowdin
  Update status check for all supported on.pull_request.types in Gitea (go-gitea#33117)
  Support the new exit code for `git remote` subcommands for git version >=2.30.0 (go-gitea#33129)
  Make git clone URL could use current signed-in user (go-gitea#33091)
  Filter reviews of one pull request in memory instead of database to reduce slow response because of lacking database index (go-gitea#33106)
@yp05327 yp05327 deleted the fix-33051 branch January 8, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Update Status Check on Event
5 participants
@yp05327 @lunny @wxiaoguang @Zettat123 @GiteaBot