Fix actions rerun bug (#35783)

[Zettat123]

Backport #35783

Fix #35780, fix #35782

Rerunning a job or a run is only allowed when the job is done and the run is done.

Related PR: #34970

gitea/routers/web/repo/actions/view.go

Line 239 in 98ff7d0

resp.State.Run.CanRerun = run.Status.IsDone() && ctx.Repo.CanWrite(unit.TypeActions)

We don't need to check run status again in rerunJob because the run status has been changed before rerunJob.

---

In fact, the bug described in the above issues will not occur on the main branch. Because getRunJobs is called before updating the run.

gitea/routers/web/repo/actions/view.go

Lines 425 to 435 in 98ff7d0

	job, jobs := getRunJobs(ctx, runIndex, jobIndex)
	if ctx.Written() {
	return
	}
	// reset run's start and stop time when it is done
	if run.Status.IsDone() {
	run.PreviousDuration = run.Duration()
	run.Started = 0
	run.Stopped = 0
	run.Status = actions_model.StatusWaiting

So the run status that rerunJob checks is the old status.

[wxiaoguang]

I think we can say "this PR fixes ..." now 😆

[NorthRealm]

Literally... 🤷

[ZeroDeng01]

I think we can say "this PR fixes ..." now 😆

Hope to release the patch successfully🧐

[wxiaoguang]

I think we can say "this PR fixes ..." now 😆

Literally... 🤷

Hope to release the patch successfully🧐

I mean the bug doesn't really exist on main branch 😁

[ZeroDeng01]

I think we can say "this PR fixes ..." now 😆

Literally... 🤷
Hope to release the patch successfully🧐

I mean the bug doesn't really exist on main branch 😁

As you said, I temporarily switched to the main-nightly tag to keep the system running normally.