Fix circular spin animation direction #35785

lutinglt · 2025-10-30T02:52:11Z

Wait for the status icon to rotate clockwise instead of counterclockwise

before:

after:

This can be merged to 1.25

wxiaoguang · 2025-10-30T03:15:58Z

Please read and fix the comment

lutinglt · 2025-10-30T04:30:18Z

Please read and fix the comment

Now, we have our own icon that can rotate clockwise (

wxiaoguang · 2025-10-30T04:37:27Z

@silverwind what do you think about the new change? It looks good to me.

lutinglt · 2025-10-30T05:33:22Z

@silverwind what do you think about the new change? It looks good to me.

I have a better idea. 'octicon sync' is a counterclockwise icon used to represent the state of rollback or rerun. If it is a rollback or rerun, we should use a counterclockwise icon and a counterclockwise rotation animation. If it is ongoing, first-time, or one-time execution, we should use a clockwise icon and a clockwise rotation animation. This can be a bit troublesome because I am not very clear about the specific purpose of some pages.

wxiaoguang · 2025-10-30T05:38:56Z

Maybe no need to make it that complex. When it is a static icon, I guess few people would really look carefully at it to see whether it is clockwise or counterclockwise

lutinglt · 2025-10-30T05:46:22Z

Maybe no need to make it that complex. When it is a static icon, I guess few people would really look carefully at it to see whether it is clockwise or counterclockwise

Emmm, Maybe it's still quite obvious?

silverwind · 2025-10-30T08:02:26Z

Maybe we should just use the dot-in-circle icon in all cases where we had animate the other one, which would make it never spin, and therefor we would not need to have the flipped icon being animated.
Can we rename the animation to rotate-clockwise?

lutinglt · 2025-10-30T08:44:43Z

Maybe we should just use the dot-in-circle icon in all cases where we had animate the other one, which would make it never spin, and therefor we would not need to have the flipped icon being animated.

Can we rename the animation to rotate-clockwise?

I agree, but I can't see the specific page. It seems like there's no problem looking at the code? If possible, I will modify and submit it like this.

silverwind · 2025-10-30T09:28:36Z

Should be safe to replace "blindly" if the icon size is the same.

Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

lutinglt · 2025-10-31T07:27:28Z

The viewBox for octicon-sync and gitea-running is the same. I will replace the octicon-sync icon with gitea-running for the circular-pine animation and rename the circular-pine animation class name to rotate-clockwise

Wait for the status icon to rotate clockwise instead of counterclockwise before: ![GIF 2025-10-30 10-50-07](https://github.com/user-attachments/assets/3771b0bf-44e4-45a0-bde5-1b2b3dd8ba2a) after: ![GIF 2025-10-30 10-50-43](https://github.com/user-attachments/assets/c45307fe-39a4-4e60-b48e-9d922c407565) --------- Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com> Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: lutinglt <lutinglt@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

* giteaofficial/main: Add cache to container build (go-gitea#35697) Revert gomail to v0.7.0 to fix sending mail failed (go-gitea#35816) Fix circular spin animation direction (go-gitea#35785) Fix clone mixed bug (go-gitea#35810) [skip ci] Updated translations via Crowdin Remove unnecessary function parameter (go-gitea#35765) Fix cli "Before" handling (go-gitea#35797) Add test for ExtendCommentTreePathLength migration and fix bugs (go-gitea#35791) Fix file extension on gogs.png (go-gitea#35793) Improve and fix markup code preview rendering (go-gitea#35777)

@lutinglt

Backport #35785 by @lutinglt Wait for the status icon to rotate clockwise instead of counterclockwise before: ![GIF 2025-10-30 10-50-07](https://github.com/user-attachments/assets/3771b0bf-44e4-45a0-bde5-1b2b3dd8ba2a) after: ![GIF 2025-10-30 10-50-43](https://github.com/user-attachments/assets/c45307fe-39a4-4e60-b48e-9d922c407565) This can be merged to 1.25 Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com> Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com> Co-authored-by: lutinglt <lutinglt@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [go-gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.25.0` -> `1.25.1` | --- ### Release Notes <details> <summary>go-gitea/gitea (go-gitea/gitea)</summary> ### [`v1.25.1`](https://github.com/go-gitea/gitea/releases/tag/v1.25.1) [Compare Source](go-gitea/gitea@v1.25.0...v1.25.1) - BUGFIXES - Make ACME email optional ([#35849](go-gitea/gitea#35849)) [#35857](go-gitea/gitea#35857) - Add a doctor command to fix inconsistent run status ([#35840](go-gitea/gitea#35840)) ([#35845](go-gitea/gitea#35845)) - Remove wrong code ([#35846](go-gitea/gitea#35846)) - Fix viewed files number is not right if not all files loaded ([#35821](go-gitea/gitea#35821)) ([#35844](go-gitea/gitea#35844)) - Fix incorrect pull request counter ([#35819](go-gitea/gitea#35819)) ([#35841](go-gitea/gitea#35841)) - Upgrade go mail to 0.7.2 and fix the bug ([#35833](go-gitea/gitea#35833)) ([#35837](go-gitea/gitea#35837)) - Revert gomail to v0.7.0 to fix sending mail failed ([#35816](go-gitea/gitea#35816)) ([#35824](go-gitea/gitea#35824)) - Fix clone mixed bug ([#35810](go-gitea/gitea#35810)) ([#35822](go-gitea/gitea#35822)) - Fix cli "Before" handling ([#35797](go-gitea/gitea#35797)) ([#35808](go-gitea/gitea#35808)) - Improve and fix markup code preview rendering ([#35777](go-gitea/gitea#35777)) ([#35787](go-gitea/gitea#35787)) - Fix actions rerun bug ([#35783](go-gitea/gitea#35783)) ([#35784](go-gitea/gitea#35784)) - Fix actions schedule update issue ([#35767](go-gitea/gitea#35767)) ([#35774](go-gitea/gitea#35774)) - Fix circular spin animation direction ([#35785](go-gitea/gitea#35785)) ([#35823](go-gitea/gitea#35823)) - Fix file extension on gogs.png ([#35793](go-gitea/gitea#35793)) ([#35799](go-gitea/gitea#35799)) - Add pnpm to Snapcraft ([#35778](go-gitea/gitea#35778)) Instances on **[Gitea Cloud](https://cloud.gitea.com)** will be automatically upgraded to this version during the specified maintenance window. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.com/gitea/helm-gitea/pulls/981 Reviewed-by: Markus Pesch <volker.raschek@noreply.gitea.com> Co-authored-by: Renovate Bot <renovate-bot@gitea.com> Co-committed-by: Renovate Bot <renovate-bot@gitea.com>

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 30, 2025

github-actions bot added the modifies/frontend label Oct 30, 2025

silverwind added the backport/v1.25 label Oct 30, 2025

silverwind approved these changes Oct 30, 2025

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2025

wxiaoguang marked this pull request as draft October 30, 2025 03:30

github-actions bot added the modifies/templates This PR modifies the template files label Oct 30, 2025

wxiaoguang marked this pull request as ready for review October 30, 2025 04:37

lutinglt marked this pull request as draft October 30, 2025 08:07

github-actions bot added modifies/templates This PR modifies the template files and removed modifies/templates This PR modifies the template files labels Oct 31, 2025

lutinglt and others added 6 commits October 31, 2025 15:22

Fix circular spin animation direction

66451c3

Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com>

octicon-sync -> gitea-sync

5794b0e

Remove unused octiconSync import

4030370

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

rollback gitea-sync -> octicon-sync

edcfa54

circular-spin: octicon-sync -> gitea-running

f01ae48

circular-spin -> rotate-clockwise

0960631

lutinglt force-pushed the main branch from e0c983f to 0960631 Compare October 31, 2025 07:22

lutinglt marked this pull request as ready for review October 31, 2025 07:39

lutinglt requested a review from silverwind October 31, 2025 07:48

GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 31, 2025

silverwind approved these changes Oct 31, 2025

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 31, 2025

lunny approved these changes Nov 2, 2025

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2025

Merge branch 'main' into main

055d479

lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 2, 2025

Merge branch 'main' into main

6035ae7

lunny enabled auto-merge (squash) November 2, 2025 07:54

GiteaBot mentioned this pull request Nov 2, 2025

Fix circular spin animation direction (#35785) #35823

Merged

GiteaBot added the backport/done All backports for this PR have been created label Nov 2, 2025

lunny merged commit f2d7931 into go-gitea:main Nov 2, 2025
26 checks passed

GiteaBot added this to the 1.26.0 milestone Nov 2, 2025

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix circular spin animation direction #35785

Fix circular spin animation direction #35785

Uh oh!

lutinglt commented Oct 30, 2025 •

edited

Loading

Uh oh!

wxiaoguang commented Oct 30, 2025 •

edited

Loading

Uh oh!

lutinglt commented Oct 30, 2025

Uh oh!

wxiaoguang commented Oct 30, 2025

Uh oh!

lutinglt commented Oct 30, 2025

Uh oh!

wxiaoguang commented Oct 30, 2025

Uh oh!

lutinglt commented Oct 30, 2025 •

edited

Loading

Uh oh!

silverwind commented Oct 30, 2025 •

edited

Loading

Uh oh!

lutinglt commented Oct 30, 2025

Uh oh!

silverwind commented Oct 30, 2025

Uh oh!

lutinglt commented Oct 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Fix circular spin animation direction #35785

Fix circular spin animation direction #35785

Uh oh!

Conversation

lutinglt commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lutinglt commented Oct 30, 2025

Uh oh!

wxiaoguang commented Oct 30, 2025

Uh oh!

lutinglt commented Oct 30, 2025

Uh oh!

wxiaoguang commented Oct 30, 2025

Uh oh!

lutinglt commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lutinglt commented Oct 30, 2025

Uh oh!

silverwind commented Oct 30, 2025

Uh oh!

lutinglt commented Oct 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lutinglt commented Oct 30, 2025 •

edited

Loading

wxiaoguang commented Oct 30, 2025 •

edited

Loading

lutinglt commented Oct 30, 2025 •

edited

Loading

silverwind commented Oct 30, 2025 •

edited

Loading