Fix LDAP GetError and LDAP search #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update go-asn1-ber * Remove unnecessary dependency for go-asn1-ber v1.5.4 through "go mod tidy"
Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com> Co-authored-by: Christopher Puschmann <cp@lumen.sh>
…o-ldap#466) Parallel and large amount of fuzzing data can create large amounts of allocated data and cause restricted fuzzing environments to crash (see go-ldap#460)
… of changing ber's module global variable for fuzz tests go-ldap#472 (go-ldap#473)
…occurs (go-ldap#474) Co-authored-by: John Weldon <johnweldon4@gmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.13.0 to 0.17.0. - [Commits](golang/crypto@v0.13.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.13.0 to 0.17.0. - [Commits](golang/crypto@v0.13.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: Add support for children scope choice const * Add comment to `ScopeChildren` that this scope may not be available on directory server other than OpenLDAP * Mirror changes to v3 --------- Co-authored-by: sirzzang <sirzzan@naver.com> Co-authored-by: Christopher Puschmann <cp@lumen.sh>
* feat: unix gssapi client * fix: lint errors * fix: comment grammar --------- Co-authored-by: Levko Burburas <levko.burburas@biptec.com>
Refer to https://go.dev/wiki/Deprecated The right way to mark a function as deprecated is to use `Deprecated:` as the beginning of a doc comment paragraph. This ensures that various tools (such as static checks) pick up the deprecation information.
…chAsync() (go-ldap#496) * Refactor the context handling with receiving an ldap response in searchAsync() go-ldap#495 * Add debug print for response
* Add newly added features and RFCs to the list * Removed the Travis CI link as it has been replaced with Github Actions
…bility when called (go-ldap#499)
go-ldap#500) * Revert "fix: Limit maximum BER packet length in `FuzzParseDN` to 65536 bytes (go-ldap#466)" This reverts commit 80095a3 * Fix index out of range crash
* Update golang.org/x/crypto * Forgot to mirror to v3 * update asn1-ber
* add tests to parseDN (including fuzz tests) and apply changes required to make roundtripping work Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> * undo unnessary changes Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> --------- Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
…es (go-ldap#505) * fix: Replace DER with ASN1 BER encoding when parsing distinguishedNames * Remove leftover comment
|
@cpuschma how can I get this PR to be reviewed? |
johnweldon
requested changes
Apr 18, 2024
|
@johnweldon changes done |
cpuschma
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At error.go, if Value is nil, then the cast will fail.
At search.go, there add an extra check to ensure presence of the attribute when collecting the entries of a successful search.