Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/scim: fix duplicate service account users and changing token #10735

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Aug 2, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner August 2, 2024 11:29
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit d31fd80
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66acc36afa1ce900088e093b

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit d31fd80
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66acc36a1e6650000861faff
😎 Deploy Preview https://deploy-preview-10735--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the sources/scim/fix-duplicate-users branch from 6065c3c to d31fd80 Compare August 2, 2024 11:30
@BeryJu
Copy link
Member Author

BeryJu commented Aug 2, 2024

/cherry-pick version-2024.6

@BeryJu BeryJu enabled auto-merge (squash) August 2, 2024 11:34
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (50c76e8) to head (d31fd80).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10735      +/-   ##
==========================================
- Coverage   92.58%   92.50%   -0.08%     
==========================================
  Files         720      720              
  Lines       35255    35255              
==========================================
- Hits        32642    32614      -28     
- Misses       2613     2641      +28     
Flag Coverage Δ
e2e 49.61% <100.00%> (-0.13%) ⬇️
integration 25.35% <50.00%> (ø)
unit 90.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 3541ec4 into main Aug 2, 2024
66 checks passed
@BeryJu BeryJu deleted the sources/scim/fix-duplicate-users branch August 2, 2024 11:50
Copy link
Contributor

Cherry-pick failed with Merge error 3541ec467c448db1353eca3d595475f6196018f5 into temp-cherry-pick-6b8b15-version-2024.6

Copy link
Contributor

github-actions bot commented Aug 2, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d31fd80940fb136eff3ba468d4d259b03ca0add8
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-d31fd80940fb136eff3ba468d4d259b03ca0add8-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d31fd80940fb136eff3ba468d4d259b03ca0add8

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-d31fd80940fb136eff3ba468d4d259b03ca0add8-arm64

Afterwards, run the upgrade commands from the latest release notes.

BeryJu added a commit that referenced this pull request Aug 2, 2024
… (cherry-pick #10735) (#10737)

sources/scim: fix duplicate service account users and changing token (#10735)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants