Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: Fix websocket default config for nginx proxy manager #11621

Merged
merged 4 commits into from
Oct 16, 2024
Merged

website/docs: Fix websocket default config for nginx proxy manager #11621

merged 4 commits into from
Oct 16, 2024

Conversation

MahmoudAlyuDeen
Copy link
Contributor

@MahmoudAlyuDeen MahmoudAlyuDeen commented Oct 6, 2024

Details

Update suggested configuration replacing commenting out lines that cause Nginx Proxy Manager host to go offline.

Resolves:

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

@MahmoudAlyuDeen MahmoudAlyuDeen requested a review from a team as a code owner October 6, 2024 22:07
Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 213b430
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/670fd1318027d20008886b7d
😎 Deploy Preview https://deploy-preview-11621--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 213b430
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/670fd1315992450008a9e7ab
😎 Deploy Preview https://deploy-preview-11621--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@BeryJu BeryJu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from being baffled how this standard nginx configuration breaking NPM, if anything I dont think it should be commented out but rather removed, as it being commented out without a reason makes it even more confusing

Signed-off-by: Mahmoud AlyuDeen <mahmoudalyudeen@gmail.com>
@MahmoudAlyuDeen MahmoudAlyuDeen changed the title Comment out problematic config at _nginx_proxy_manager.md Fix websocket default config at _nginx_proxy_manager.md Oct 13, 2024
@MahmoudAlyuDeen
Copy link
Contributor Author

if anything I dont think it should be commented out but rather removed

Makes sense. I've replaced the current setup with a working and tested websocket setup - and kept it commented out by default.

I updated the PR title and description accordingly.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu changed the title Fix websocket default config at _nginx_proxy_manager.md website/docs: Fix websocket default config for nginx proxy manager Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (01e7124) to head (213b430).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11621   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         736      736           
  Lines       36609    36609           
=======================================
+ Hits        33956    33957    +1     
+ Misses       2653     2652    -1     
Flag Coverage Δ
e2e 49.38% <ø> (+<0.01%) ⬆️
integration 24.96% <ø> (ø)
unit 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit f531dd9 into goauthentik:main Oct 16, 2024
61 checks passed
kensternberg-authentik added a commit that referenced this pull request Oct 18, 2024
* main: (68 commits)
  core: extract object matching from flow manager (#11458)
  admin: store version history (#11520)
  web: bump API Client version (#11706)
  providers/oauth2: add initial JWE support (#11344)
  core, web: update translations (#11703)
  tests/e2e: add forward auth e2e test (#11374)
  web/admin: fix duplicate flow labels (#11689)
  providers/saml: fix incorrect ds:Reference URI (#11699)
  website/docs: Fix websocket default config for nginx proxy manager (#11621)
  core, web: update translations (#11692)
  core: bump uvicorn from 0.31.1 to 0.32.0 (#11693)
  core: bump github.com/prometheus/client_golang from 1.20.4 to 1.20.5 (#11694)
  website/docs: add missing file to sidebar (#11695)
  website/docs: rewrote too long sentence (#11696)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#11697)
  translate: Updates for file web/xliff/en.xlf in fr (#11698)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11683)
  core, web: update translations (#11682)
  core: bump github.com/getsentry/sentry-go from 0.29.0 to 0.29.1 (#11684)
  core: bump github.com/redis/go-redis/v9 from 9.6.1 to 9.6.2 (#11685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants