Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/saml: fix incorrect ds:Reference URI #11699

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 16, 2024

Details

closes #11604


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner October 16, 2024 14:36
@BeryJu
Copy link
Member Author

BeryJu commented Oct 16, 2024

/cherry-pick version-2024.8

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit e6991f0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/670fcf6cc349390007f9b521

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit e6991f0
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/670fcf6ca7a1e80008d34fef

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (01e7124) to head (e6991f0).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11699   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         736      736           
  Lines       36609    36613    +4     
=======================================
+ Hits        33956    33962    +6     
+ Misses       2653     2651    -2     
Flag Coverage Δ
e2e 49.38% <66.66%> (+<0.01%) ⬆️
integration 24.96% <0.00%> (-0.01%) ⬇️
unit 90.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-e6991f095ef24a5631d883eb1a849d0768b1ea82
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-e6991f095ef24a5631d883eb1a849d0768b1ea82-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-e6991f095ef24a5631d883eb1a849d0768b1ea82

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-e6991f095ef24a5631d883eb1a849d0768b1ea82-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 6cc0a66 into main Oct 16, 2024
66 checks passed
@BeryJu BeryJu deleted the providers/saml/fix-incorrect-signature-reference branch October 16, 2024 15:17
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 16, 2024
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Oct 16, 2024
…11701)

providers/saml: fix incorrect ds:Reference URI (#11699)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L. <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Oct 18, 2024
* main: (68 commits)
  core: extract object matching from flow manager (#11458)
  admin: store version history (#11520)
  web: bump API Client version (#11706)
  providers/oauth2: add initial JWE support (#11344)
  core, web: update translations (#11703)
  tests/e2e: add forward auth e2e test (#11374)
  web/admin: fix duplicate flow labels (#11689)
  providers/saml: fix incorrect ds:Reference URI (#11699)
  website/docs: Fix websocket default config for nginx proxy manager (#11621)
  core, web: update translations (#11692)
  core: bump uvicorn from 0.31.1 to 0.32.0 (#11693)
  core: bump github.com/prometheus/client_golang from 1.20.4 to 1.20.5 (#11694)
  website/docs: add missing file to sidebar (#11695)
  website/docs: rewrote too long sentence (#11696)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#11697)
  translate: Updates for file web/xliff/en.xlf in fr (#11698)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11683)
  core, web: update translations (#11682)
  core: bump github.com/getsentry/sentry-go from 0.29.0 to 0.29.1 (#11684)
  core: bump github.com/redis/go-redis/v9 from 9.6.1 to 9.6.2 (#11685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SAML response contains duplicate sections of "ds:Reference"
1 participant