Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/scim: cleanup service account when source is deleted #9319

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 17, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner April 17, 2024 15:49
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 5375090
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6620379c4774fa00087bcf2b

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 5375090
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6620379c1145440008f4506f

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (8935ca6) to head (49c6447).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9319      +/-   ##
==========================================
+ Coverage   90.15%   90.80%   +0.65%     
==========================================
  Files         665      667       +2     
  Lines       32613    32630      +17     
==========================================
+ Hits        29402    29631     +229     
+ Misses       3211     2999     -212     
Flag Coverage Δ
e2e 48.96% <25.00%> (+3.22%) ⬆️
unit 89.68% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu force-pushed the sources/scim/cleanup-sa branch from 6bf0e89 to 49c6447 Compare April 17, 2024 16:03
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the sources/scim/cleanup-sa branch from 49c6447 to 5375090 Compare April 17, 2024 20:56
@BeryJu BeryJu merged commit 49ac0eb into main Apr 17, 2024
2 checks passed
@BeryJu BeryJu deleted the sources/scim/cleanup-sa branch April 17, 2024 20:57
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-5375090d7011d1bff722844e778bd7a37b95e062
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-5375090d7011d1bff722844e778bd7a37b95e062-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-5375090d7011d1bff722844e778bd7a37b95e062

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-5375090d7011d1bff722844e778bd7a37b95e062-arm64

Afterwards, run the upgrade commands from the latest release notes.

kensternberg-authentik added a commit that referenced this pull request Apr 18, 2024
…rities' into web/bug/locale-priorities

* refs/remotes/origin/web/bug/locale-priorities:
  web: fix locale prioritization scheme
  core: bump aiohttp from 3.9.2 to 3.9.4 (#9339)
  stages/prompt: fix username field throwing error with existing user (#9342)
  root: expose session storage configuration (#9337)
  website/integrations: fix typo (#9340)
  root: fix go.mod for codeql checking (#9338)
  root: make redis settings more consistent (#9335)
  web/admin: fix error in admin interface due to un-hydrated context (#9336)
  web: bump API Client version (#9334)
  stages/authenticator_webauthn: fix attestation value (#9333)
  website/docs: fix SECRET_KEY length (#9328)
  website/docs: fix email template formatting (#9330)
  core, web: update translations (#9323)
  web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324)
  core: bump celery from 5.3.6 to 5.4.0 (#9325)
  core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327)
  sources/scim: service account should be internal (#9321)
  web: bump the storybook group in /web with 8 updates (#9266)
  sources/scim: cleanup service account when source is deleted (#9319)
kensternberg-authentik added a commit that referenced this pull request Apr 19, 2024
* main:
  stages/prompt: fix username field throwing error with existing user (#9342)
  root: expose session storage configuration (#9337)
  website/integrations: fix typo (#9340)
  root: fix go.mod for codeql checking (#9338)
  root: make redis settings more consistent (#9335)
  web/admin: fix error in admin interface due to un-hydrated context (#9336)
  web: bump API Client version (#9334)
  stages/authenticator_webauthn: fix attestation value (#9333)
  website/docs: fix SECRET_KEY length (#9328)
  website/docs: fix email template formatting (#9330)
  core, web: update translations (#9323)
  web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324)
  core: bump celery from 5.3.6 to 5.4.0 (#9325)
  core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327)
  sources/scim: service account should be internal (#9321)
  web: bump the storybook group in /web with 8 updates (#9266)
  sources/scim: cleanup service account when source is deleted (#9319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant