Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/admin: fix error in admin interface due to un-hydrated context #9336

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 18, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner April 18, 2024 14:11
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 360ea2b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/662129fa36573a00084993c0

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 360ea2b
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/662129fa8840200007bee10d
😎 Deploy Preview https://deploy-preview-9336--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (9f5d708) to head (360ea2b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9336      +/-   ##
==========================================
+ Coverage   92.39%   92.41%   +0.01%     
==========================================
  Files         667      667              
  Lines       32629    32629              
==========================================
+ Hits        30147    30153       +6     
+ Misses       2482     2476       -6     
Flag Coverage Δ
e2e 50.74% <ø> (+0.05%) ⬆️
integration 26.03% <ø> (ø)
unit 89.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kensternberg-authentik kensternberg-authentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sort of thing I was hoping to avoid; I really don't want our UI to be dependent upon values that aren't derived from API, so that it can be deployed and used standalone. For the time being, though, the environment contains these values, so this is acceptable.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-360ea2b365df123d14ee47a9e6e7e5b3c898fc3b
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-360ea2b365df123d14ee47a9e6e7e5b3c898fc3b-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-360ea2b365df123d14ee47a9e6e7e5b3c898fc3b

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-360ea2b365df123d14ee47a9e6e7e5b3c898fc3b-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 2e9df96 into main Apr 18, 2024
67 checks passed
@BeryJu BeryJu deleted the web/admin/fix-context-error branch April 18, 2024 14:49
kensternberg-authentik added a commit that referenced this pull request Apr 18, 2024
…rities' into web/bug/locale-priorities

* refs/remotes/origin/web/bug/locale-priorities:
  web: fix locale prioritization scheme
  core: bump aiohttp from 3.9.2 to 3.9.4 (#9339)
  stages/prompt: fix username field throwing error with existing user (#9342)
  root: expose session storage configuration (#9337)
  website/integrations: fix typo (#9340)
  root: fix go.mod for codeql checking (#9338)
  root: make redis settings more consistent (#9335)
  web/admin: fix error in admin interface due to un-hydrated context (#9336)
  web: bump API Client version (#9334)
  stages/authenticator_webauthn: fix attestation value (#9333)
  website/docs: fix SECRET_KEY length (#9328)
  website/docs: fix email template formatting (#9330)
  core, web: update translations (#9323)
  web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324)
  core: bump celery from 5.3.6 to 5.4.0 (#9325)
  core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327)
  sources/scim: service account should be internal (#9321)
  web: bump the storybook group in /web with 8 updates (#9266)
  sources/scim: cleanup service account when source is deleted (#9319)
kensternberg-authentik added a commit that referenced this pull request Apr 19, 2024
* main:
  stages/prompt: fix username field throwing error with existing user (#9342)
  root: expose session storage configuration (#9337)
  website/integrations: fix typo (#9340)
  root: fix go.mod for codeql checking (#9338)
  root: make redis settings more consistent (#9335)
  web/admin: fix error in admin interface due to un-hydrated context (#9336)
  web: bump API Client version (#9334)
  stages/authenticator_webauthn: fix attestation value (#9333)
  website/docs: fix SECRET_KEY length (#9328)
  website/docs: fix email template formatting (#9330)
  core, web: update translations (#9323)
  web: bump @patternfly/elements from 3.0.0 to 3.0.1 in /web (#9324)
  core: bump celery from 5.3.6 to 5.4.0 (#9325)
  core: bump goauthentik.io/api/v3 from 3.2024022.12 to 3.2024023.1 (#9327)
  sources/scim: service account should be internal (#9321)
  web: bump the storybook group in /web with 8 updates (#9266)
  sources/scim: cleanup service account when source is deleted (#9319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants