feat(DashboardTableEfficiency): update UI for relative values in th…
#1149
+40
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying beaconchain with
|
| Latest commit: |
7b6d885
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10aaa5e9.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-844-relative-values-in.beaconchain.pages.dev |
benji-bitfly
force-pushed
the
BEDS-844/relative-values-in-summary
branch
from
afac4dd
to
52b6fcc
Compare
benji-bitfly
force-pushed
the
BEDS-844/relative-values-in-summary
branch
8 times, most recently
from
8827ea9
to
d62d1df
Compare
…equal to `0` Improve `UX` by displaying `-` for `0` values. See: BEDS-844
It is easier to work with components if their name reflect the file path in nuxt.
benji-bitfly
force-pushed
the
BEDS-844/relative-values-in-summary
branch
from
d62d1df
to
7b6d885
Compare
|
np: |
| <BcFormatNumber | ||
| :class="data.failedClass" | ||
| :value="props.failed" | ||
| <span v-if="props.success === 0 && props.failed === 0">0 / 0</span> |
There was a problem hiding this comment.
how would 50/70 be displayed?
50/50or50 / 50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e
validator summaryDisplay
-when relative values are equal to0.See: BEDS-844