Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate defaults for ana.malloc.unique_address_count in SV-Comp #1168

Open
michael-schwarz opened this issue Sep 14, 2023 · 4 comments
Open
Labels
precision sv-comp SV-COMP (analyses, results), witnesses
Milestone

Comments

@michael-schwarz
Copy link
Member

No description provided.

@sim642
Copy link
Member

sim642 commented Nov 21, 2023

This was changed to 5 in #1234, so I suppose we can consider it done for now?

@michael-schwarz
Copy link
Member Author

This was only changed for MemSafety, one might want to re-evaluate it also for the other categories.

@michael-schwarz michael-schwarz added the sv-comp SV-COMP (analyses, results), witnesses label Nov 22, 2023
sim642 added a commit to sim642/opam-repository that referenced this issue Nov 24, 2023
nberth pushed a commit to nberth/opam-repository that referenced this issue Jun 18, 2024
@karoliineh
Copy link
Member

karoliineh commented Jun 21, 2024

@sim642 made a run with --set ana.malloc.unique_address_count 1 on sv-benchmarks with no-overflow property. This gives 31 new correct results with a 60s timeout. However, it costs us a 14% slowdown as well.

So, for the best-case scenario, we should

  • try to autotune it so that we only set ana.malloc.unique_address_count > 0 for programs with allocs that are not in loops and see if that helps with the loss in performance;
  • try out different values to see which is the best default for no-overflows;
  • inspect other categories in addition to MemSafety and no-overflows.

However, if we do not manage to do all that before SV-COMP 2025, we could at least enable it with 1 for no-overflows.

@sim642
Copy link
Member

sim642 commented Oct 22, 2024

However, if we do not manage to do all that before SV-COMP 2025, we could at least enable it with 1 for no-overflows.

This should be a fairly simple change to do now, so feel free to open a PR. I think I still have the 60s no-overflows run diff here: https://goblint.cs.ut.ee/results/191-no-overflow-pr-1511-before-alloc-1/table-generator-cmp.diff.html#/.
We can postpone other additional improvements to SV-COMP 2026 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
precision sv-comp SV-COMP (analyses, results), witnesses
Projects
None yet
Development

No branches or pull requests

3 participants