Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotuner: Do not activate Apron for val variables from Goblint header for __VERIFIER_nondet_* #987

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

michael-schwarz
Copy link
Member

Currently, the autotuner enables tracking relational information about variables used to implement __VERIFIER_nondet_* functions.

This PR introduces attribute goblint_stub for variables to prevent tracking them relationally and marks the variables with this attribute.

Closes #921

@michael-schwarz michael-schwarz added cleanup Refactoring, clean-up sv-comp SV-COMP (analyses, results), witnesses labels Feb 12, 2023
Copy link
Member

@jerhard jerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice to see that you found a simple fix for this.

Just for reference: There already is a goblint_stub attribute for functions: It is used to exclude those functions from functions with dead lines of code, and to exclude them from being analyzed as a thread when the "allfuns" option is active. I do not think that these different effects of the goblint_stub attribute are a problem however, since they are really consequence of the function/variable being a stub / part of a stub.

tests/regression/46-apron2/30-autotune-stub.c Outdated Show resolved Hide resolved
src/autoTune.ml Outdated Show resolved Hide resolved
@michael-schwarz michael-schwarz merged commit 219750f into master Feb 14, 2023
@michael-schwarz michael-schwarz deleted the issue-921 branch February 14, 2023 08:59
@sim642 sim642 added this to the SV-COMP 2024 milestone Apr 5, 2023
sim642 added a commit to sim642/opam-repository that referenced this pull request Nov 24, 2023
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up sv-comp SV-COMP (analyses, results), witnesses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autotuner: Do not activate Apron for val variables from Goblint header for __VERIFIER_nondet_*
3 participants