Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MayLock Analysis & Sanity Checks of Mutex Usage & Analysis of Mutex Types #839

Merged
merged 57 commits into from
May 29, 2023

Conversation

michael-schwarz
Copy link
Member

@michael-schwarz michael-schwarz commented Sep 22, 2022

Some in-progress work on a May Lock Analysis that allows us to detect potential may double locking. Also contains some first attempt of tracking whether a mutex is potentially recursive or not, in order to emit appropriate warnings.

Relates (partially) to:

  1. Mutex/thread sanity analysis #176
  2. Proper support for mutex type PTHREAD_MUTEX_ERRORCHECK checking return types #658
  3. Switch to HoareSet for MayLocks #718
  4. Maintain more precise lockset for recursive mutexes #800

@michael-schwarz michael-schwarz changed the title MayLock Analysis using Hoare Address Domain MayLock Analysis using Hoare Address Domain & Sanity Checks of Mutex Usage Sep 22, 2022
@michael-schwarz michael-schwarz changed the title MayLock Analysis using Hoare Address Domain & Sanity Checks of Mutex Usage MayLock Analysis using Hoare Address Domain & Sanity Checks of Mutex Usage & Analysis of Mutex Types Sep 25, 2022
@michael-schwarz michael-schwarz marked this pull request as draft May 25, 2023 15:16
@michael-schwarz michael-schwarz marked this pull request as ready for review May 25, 2023 16:44
@michael-schwarz michael-schwarz requested a review from sim642 May 25, 2023 16:44
src/analyses/mutexTypeAnalysis.ml Outdated Show resolved Hide resolved
src/analyses/mutexTypeAnalysis.ml Outdated Show resolved Hide resolved
src/analyses/mutexTypeAnalysis.ml Outdated Show resolved Hide resolved
src/analyses/mutexTypeAnalysis.ml Outdated Show resolved Hide resolved
src/cdomains/lval.ml Outdated Show resolved Hide resolved
src/domains/queries.ml Outdated Show resolved Hide resolved
@michael-schwarz michael-schwarz changed the title MayLock Analysis using Hoare Address Domain & Sanity Checks of Mutex Usage & Analysis of Mutex Types MayLock Analysis & Sanity Checks of Mutex Usage & Analysis of Mutex Types May 26, 2023
Copy link
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last big question is how expensive these things are. Ideally we could just have these activated by default.

@michael-schwarz
Copy link
Member Author

I will merge them for now (without changing the defaults), and do an sv-comp run after!

@michael-schwarz michael-schwarz merged commit bdb69f0 into master May 29, 2023
@michael-schwarz michael-schwarz deleted the issue_718 branch May 29, 2023 13:59
sim642 added a commit to sim642/opam-repository that referenced this pull request Sep 13, 2023
CHANGES:

* Add `setjmp`/`longjmp` analysis (goblint/analyzer#887, goblint/analyzer#970, goblint/analyzer#1015, goblint/analyzer#1019).
* Refactor race analysis to lazy distribution (goblint/analyzer#1084, goblint/analyzer#1089, goblint/analyzer#1136, goblint/analyzer#1016).
* Add thread-unsafe library function call analysis (goblint/analyzer#723, goblint/analyzer#1082).
* Add mutex type analysis and mutex API analysis (goblint/analyzer#800, goblint/analyzer#839, goblint/analyzer#1073).
* Add interval set domain and string literals domain (goblint/analyzer#901, goblint/analyzer#966, goblint/analyzer#994, goblint/analyzer#1048).
* Add affine equalities analysis (goblint/analyzer#592).
* Add use-after-free analysis (goblint/analyzer#1050, goblint/analyzer#1114).
* Add dead code elimination transformation (goblint/analyzer#850, goblint/analyzer#979).
* Add taint analysis for partial contexts (goblint/analyzer#553, goblint/analyzer#952).
* Add YAML witness validation via unassume (goblint/analyzer#796, goblint/analyzer#977, goblint/analyzer#1044, goblint/analyzer#1045, goblint/analyzer#1124).
* Add incremental analysis rename detection (goblint/analyzer#774, goblint/analyzer#777).
* Fix address sets unsoundness (goblint/analyzer#822, goblint/analyzer#967, goblint/analyzer#564, goblint/analyzer#1032, goblint/analyzer#998, goblint/analyzer#1031).
* Fix thread escape analysis unsoundness (goblint/analyzer#939, goblint/analyzer#984, goblint/analyzer#1074, goblint/analyzer#1078).
* Fix many incremental analysis issues (goblint/analyzer#627, goblint/analyzer#836, goblint/analyzer#835, goblint/analyzer#841, goblint/analyzer#932, goblint/analyzer#678, goblint/analyzer#942, goblint/analyzer#949, goblint/analyzer#950, goblint/analyzer#957, goblint/analyzer#955, goblint/analyzer#954, goblint/analyzer#960, goblint/analyzer#959, goblint/analyzer#1004, goblint/analyzer#558, goblint/analyzer#1010, goblint/analyzer#1091).
* Fix server mode for abstract debugging (goblint/analyzer#983, goblint/analyzer#990, goblint/analyzer#997, goblint/analyzer#1000, goblint/analyzer#1001, goblint/analyzer#1013, goblint/analyzer#1018, goblint/analyzer#1017, goblint/analyzer#1026, goblint/analyzer#1027).
* Add documentation for configuration JSON schema and OCaml API (goblint/analyzer#999, goblint/analyzer#1054, goblint/analyzer#1055, goblint/analyzer#1053).
* Add many library function specifications (goblint/analyzer#962, goblint/analyzer#996, goblint/analyzer#1028, goblint/analyzer#1079, goblint/analyzer#1121, goblint/analyzer#1135, goblint/analyzer#1138).
* Add OCaml 5.0 support (goblint/analyzer#1003, goblint/analyzer#945, goblint/analyzer#1162).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants