-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing MERGE to use named paths in table names #223
base: main
Are you sure you want to change the base?
Conversation
b9fc619
to
449471d
Compare
Hi @bony2023, |
I believe it's because the emulator always pass the datasetID as empty when executing a Query. I'll see if I can fix it here directly. |
Thanks @bony2023 for all the help. |
Thanks @bony2023 for your last message. You are right and I confirm, by hard coding namePath[1] to my dataset name in your changes in this PR, everything works as expected in local emulator 🎉🎉. I am not sure if fixing this right way is possible in this lib, but thanks for being the savior here. I am new to BQ as well as Go, and was trying to figure this out for last two days, and you saved me here. |
449471d
to
5d04344
Compare
I just pushed a commit to extract datasetID if it's not provided in namePath from the emulator. |
5d04344
to
9a668f1
Compare
9a668f1
to
a319e2e
Compare
@bony2023 Sorry for delay in responding. Your latest commit works very well. Thank you so much. 🎉🎉🎉🎉🎉 |
when will this be merged? |
Closes: goccy/bigquery-emulator#299
The sub-actions (INSERT, UPDATE and DELETE) inside the merge statement currently do not work when using BigQuery Emulator, as they are not able to recognize the exact table they need to work upon.
This PR fixes the logic by adding namePath to the source and target table names joined by underscore to work on sqlite tables.