Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid stripping out the form html from the enroll form shown to logged in users, and block output (ie. Groups) #227

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

brianhogg
Copy link
Contributor

@brianhogg brianhogg commented Jul 24, 2024

Description

The output for the pricing table block was using wp_kses_post vs. our allowed form HTML tags, so the form used to enroll logged in allowed users was being stripped (ie. logged in as admin, go to a course the admin is not enrolled in already that has a free access plan). This uses the form HTML instead.

This also affects the group settings form and any other blocks rendered out.

Fixes #228 and #229

How has this been tested?

Manually

Screenshots

Captura de pantalla 2024-07-24 a las 11 46 43 a  m Captura de pantalla 2024-07-29 a las 10 30 13 a  m

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@brianhogg brianhogg requested a review from ideadude as a code owner July 24, 2024 15:53
@brianhogg brianhogg changed the title Avoid stripping out the form html from the enroll form shown to logged in users Avoid stripping out the form html from the enroll form shown to logged in users, and block output (ie. Groups) Jul 29, 2024
@brianhogg brianhogg merged commit 466bf09 into dev Jul 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant