RawGd::move_return_ptr with PtrcallType::Virtual leaks reference

godot-rust · Aug 9, 2024 · 80cd771 · 80cd771
1 parent 817250a
commit 80cd771
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/godot-core/src/obj/raw_gd.rs b/godot-core/src/obj/raw_gd.rs
@@ -522,10 +522,10 @@ where
         if T::DynMemory::pass_as_ref(call_type) {
             interface_fn!(ref_set_object)(ptr as sys::GDExtensionRefPtr, self.obj_sys())
         } else {
-            ptr::write(ptr as *mut _, self.obj)
+            ptr::write(ptr as *mut _, self.obj);
+            // We've passed ownership to caller.
+            std::mem::forget(self);
         }
-        // We've passed ownership to caller.
-        std::mem::forget(self);
     }
 }