Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Color functions #123

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Implement Color functions #123

merged 1 commit into from
Feb 19, 2023

Conversation

ttencate
Copy link
Contributor

Another small step towards #6.

This implements everything except the large list of named color constants and the getters/setters for hsv, since there are no autogenerated wrappers for either of those yet.

@Bromeon Bromeon added feature Adds functionality to the library c: core Core components labels Feb 14, 2023
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I really like the ColorChannelOrder abstraction 🙂

godot-core/src/builtin/color.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/color.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/color.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/color.rs Show resolved Hide resolved
godot-core/src/builtin/color.rs Show resolved Hide resolved
godot-core/src/builtin/color.rs Outdated Show resolved Hide resolved
godot-core/src/builtin/color.rs Outdated Show resolved Hide resolved
itest/rust/src/color_test.rs Show resolved Hide resolved
@ttencate
Copy link
Contributor Author

Pushed. Going to try this one without amending all the time. Let me know once we're ready to squash.

@Bromeon
Copy link
Member

Bromeon commented Feb 19, 2023

Thanks a lot!

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 19, 2023

Build succeeded:

@bors bors bot merged commit 89c0e31 into godot-rust:master Feb 19, 2023
@Bromeon Bromeon mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: core Core components feature Adds functionality to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants