Run CI against stable Godot runtime #288
Conversation
Fix impl_variant_traits macro's FromVariant impl to work with both 4.0 and 4.1
…t types that leak when initialized.
Bromeon
added
feature
Bromeon
force-pushed
the
feature/ci-stable-godot
branch
from
8a5af51 to
1a3e2d5
Compare
|
I had problems with a segfault in |
288: Run CI against stable Godot runtime r=Bromeon a=Bromeon Adds CI jobs that **run** against stable release of the last Godot minor version (here 4.0.3). This distinction is important, as we have two dimensions of Godot versions now: * **GDExtension API** -- this is the version of the GDExtension API against which gdext is _compiled_. * **Runtime** -- this is the version of the Godot binary under which gdext _runs_. By default, most jobs include latest Godot nightly version (so that is not explicitly annotated in the names). `-nightly` means that a nightly _API_ version is used. `stableRt` means stable _runtime_ (the new jobs). Includes #285 as a base, as that is required to fix failing jobs with Godot 4.0.3 stable. Runs only clang memchecks for now; the gcc ones don't add that much, and we already have a huge number of jobs now. We may reduce this over time. Co-authored-by: Lili Zoey <lili.andersen@nrk.no> Co-authored-by: Jan Haller <bromeon@gmail.com>
Bromeon
force-pushed
the
feature/ci-stable-godot
branch
from
1a3e2d5 to
2a33264
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-288 |
|
One CI job I haven't managed to isolate the leaks, as I cannot reproduce them locally (with Win10 + WSL2), and they don't seem to follow a 1:1 per-use pattern. For example, calling To make matters worse, nightly.link is currently down too, meaning all our artifact-depending CI is not operational. If this persists, we need to migrate away from it by manually calling/searching several GitHub Actions REST APIs. Looking at their issue tracker, downtimes unfortunately seem to occur quite a lot 😕 bors try |
|
Just now, https://nightly.link seems up again, at least the website. So let's try again... bors try |
tryBuild failed: |
For now, disable failing memleak CI job (4.0.3 API, 4.1+ binary)
Addresses a regression introduced in fc4a405: > Remove several memory leaks by constructing into uninitialized pointers
Bromeon
force-pushed
the
feature/ci-stable-godot
branch
from
c803bfd to
27a3a7f
Compare
|
CI memory leak issue deferred to #298. bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Adds CI jobs that run against stable release of the last Godot minor version (here 4.0.3).
This distinction is important, as we have two dimensions of Godot versions now:
By default, most jobs include latest Godot nightly version (so that is not explicitly annotated in the names).
-nightlymeans that a nightly API version is used.stableRtmeans stable runtime (the new jobs).Includes #285 as a base, as that is required to fix failing jobs with Godot 4.0.3 stable.
Runs only clang memchecks for now; the gcc ones don't add that much, and we already have a huge number of jobs now. We may reduce this over time.