-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update type strings according to how godot 4.3 exports them currently #717
Conversation
oh i need to do runtime checks not compile time checks, that's annoying |
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-717 |
598ba92
to
31a2f5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I also started investigating this on RocketChat, but you were faster to come up with a working fix! 😀
Now we have the 4.3 differentiation logic in multiple places -- I wonder if we instead should just always pass the type name to PropertyHintInfo::with_hint_none()
and do the differentiation there?
(Same for the type string)
godot-core/src/property.rs
Outdated
} | ||
} | ||
}; | ||
|
||
(@type_string_hint $Ty:ty) => { | ||
impl TypeStringHint for $Ty { | ||
impl TypeStringHint for $Ty { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indentation is probably a mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, rustfmt isn't the best at formatting macros
yeah i did notice something in the actions after id done the changes, but it didn't seem to have progressed very far. i think im just a bit more familiar with this part of the codebase since i think i made a lot of it.
maybe yeah, i think initially i was planning on having |
31a2f5f
to
9574528
Compare
9574528
to
f0537d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I might have a look at some point if we can also reduce duplication in type_string()
(e.g. using another function), but that's less important. I'll merge to unblock the failing CI!
Makes our exports match what godotengine/godot#90716 does
i am now wondering if we have some code-duplication with the type string hint impl, but i guess we can look into that at some other point