RawGd::move_return_ptr with PtrcallType::Virtual leaks reference
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
bug
c: ffi
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-848 |
Bromeon
changed the title
RawGd::move_return_ptr with PtrcallType::Virtual leaks reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this reference leak while working on #771. The engine is creating
AudioEffectInstances which are being leaked. This is caused by theRawGd::move_return_ptrmethod.Calling Godot's
ref_set_objectcreates a new ref counted reference in the engine and increments the count by 1. Since we already hold the initial reference, the count is now at 2. Callingmem::forget(self)on our reference prevents the count from going down to 1 where it should be after we return from our function.