Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GDExtensionScriptInstanceInfo3 in 4.3 #849

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Support GDExtensionScriptInstanceInfo3 in 4.3 #849

merged 1 commit into from
Aug 12, 2024

Conversation

TitanNano
Copy link
Contributor

Support for Godot 4.3 GDExtensionScriptInstanceInfo3:

  • free_property_list_func now passes an array length, so we don't have to track it on our side anymore.
  • free_method_list_func gained the same argument.
  • get_method_argument_count_func was added and support for it has been implemented.

Bromeon
Bromeon reviewed Aug 10, 2024
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂

godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: engine Godot classes (nodes, resources, ...) labels Aug 10, 2024
@TitanNano TitanNano force-pushed the jovan/script_instance_info_3 branch from b11a5fd to a67c0d2 Compare August 11, 2024 18:55
@TitanNano TitanNano marked this pull request as ready for review August 11, 2024 18:59
@TitanNano TitanNano force-pushed the jovan/script_instance_info_3 branch from a67c0d2 to 5d88935 Compare August 11, 2024 21:13
@Bromeon Bromeon added the breaking-change Requires SemVer bump label Aug 11, 2024
@TitanNano TitanNano force-pushed the jovan/script_instance_info_3 branch from 5d88935 to 7be4dbe Compare August 11, 2024 21:31
Bromeon
Bromeon reviewed Aug 12, 2024
View reviewed changes
godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
godot-ffi/src/conv.rs Outdated Show resolved Hide resolved
godot-ffi/src/conv.rs Outdated Show resolved Hide resolved
godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
godot-core/src/obj/script.rs Show resolved Hide resolved
godot-core/src/obj/script.rs Outdated Show resolved Hide resolved
@TitanNano TitanNano force-pushed the jovan/script_instance_info_3 branch from 7be4dbe to 3502dbb Compare August 12, 2024 10:15
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-849

@Bromeon Bromeon added this pull request to the merge queue Aug 12, 2024
Merged via the queue into godot-rust:master with commit 9072095 Aug 12, 2024
14 checks passed
@TitanNano TitanNano deleted the jovan/script_instance_info_3 branch August 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon approved these changes

Assignees
No one assigned
Labels
breaking-change Requires SemVer bump c: engine Godot classes (nodes, resources, ...) quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanNano @GodotRust @Bromeon