Pass-by-ref for non-Copy builtins (frontend)
#900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables several builtins that don't implement
Copyto be passed by reference (borrowed) into engine APIs. Examples areArray,Packed*Array,Dictionary,Variant.This lays the groundwork for future optimizations which exploit borrowing to avoid unnecessary cloning/ref-count operations, thus further reducing API call overhead.
There are some ergonomic impacts of requiring
&in more places, however on the other side.clone()calls can often be avoided now. The current draft uses theBorrowtrait in a few manual APIs to enable both by-value and by-ref; I'd probably use something else that uses by-value forCopytypes and by-ref otherwise.