Allow the benchmark time limit to be changed by individual benchmarks #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Jun 18, 2024
Calinou
approved these changes
Jun 19, 2024
OverloadedOrama
added a commit
to OverloadedOrama/godot-benchmarks
that referenced
this pull request
Jun 25, 2024
Continuation of godotengine#73, fixes a crash when running C# physics benchmarks. Also sets the C# physics benchmarks to 10 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows individual benchmarks to change the benchmark time limit, which is requested for certain benchmarks, such as the physics ones (#72). Benchmarks that don't return a node are still unaffected by the limit, although I could change this if desired. This PR also sets the timer of all physics benchmarks to 10 seconds.
rigid_body_2d.gddoesn't actually have any changes besides this, the rest of the changes were formatting made by the Godot editor itself.